From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 2 of 4] x86: make the pv-only e820 array be
	dynamic
Date: Wed, 13 Apr 2011 09:31:54 -0400
Message-ID: <20110413133154.GA15870@dumpdata.com>
References: <20110412125317.GA19198@dumpdata.com> <C9CA0CCD.2C923%keir@xen.org>
	<20110412172140.GA13007@dumpdata.com>
	<4DA56E1C020000780003B4CA@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <4DA56E1C020000780003B4CA@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xensource.com, Keir Fraser <keir@xen.org>, Ian.Campbell@citrix.com, Tim.Deegan@citrix.com
List-Id: xen-devel@lists.xenproject.org

> 
> ... this "else". If you have an e820 table already, and it's too small,
> you want to not only free it, but also allocate a new one. So
> instead of an "else" you'll need a second "if" here, recovering from
> the table possibly having got freed. Since xfree(NULL) is okay, you
> could actually simply use the inner conditional on the first check.

Grrr.. Right. How embarrassing - I will blame it on the lack of sleep.