From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic Date: Wed, 13 Apr 2011 09:32:10 -0400 Message-ID: <20110413133210.GB15870@dumpdata.com> References: <20110412172140.GA13007@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, Ian Jackson , Ian.Campbell@citrix.com, Tim.Deegan@citrix.com List-Id: xen-devel@lists.xenproject.org On Wed, Apr 13, 2011 at 09:46:15AM +0100, Keir Fraser wrote: > On 12/04/2011 18:21, "Konrad Rzeszutek Wilk" wrote: > > > On Tue, Apr 12, 2011 at 02:06:05PM +0100, Keir Fraser wrote: > >> On 12/04/2011 13:53, "Konrad Rzeszutek Wilk" wrote: > >> > >>>> How cunning. > >>>> > >>>> Why wouldn't you just allocate exactly the right size of array in > >>>> XENMEM_set_memory_map? > >>> > >>> I was thinking about it, but the mm.c code did not have the > >>> xen/xmalloc.h header, nor any references to xmalloc_array. > >>> > >>> Is it OK to make an xmalloc_array during a hypercall? > >> > >> Yes. I think the toolstack should be able to clean up on the newly-possible > >> ENOMEM return from this hypercall. > > > > Hm, not sure what I am hitting, but I can't seem to be able to copy over the > > contents to the newly allocated array from the guest (this works > > fine with the previous version of the patch). This is what I get > > Your patch is not really quite right. I've attached a modified version for > you to try. Excellent, and it works quite nicely. Thank you.