Re: [RFC PATCH] Xen blkback for 2.6.40.

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Mon, Apr 18, 2011 at 11:37:04AM -0700, Daniel Stodden wrote:
> On Mon, 2011-04-18 at 13:57 -0400, Konrad Rzeszutek Wilk wrote:
> > I am proposing this patch for 2.6.40. This is an RFC at this point.
> > 
> > The git tree for this specific patch is
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git devel/xen-blkback-v3.squashed
> > 
> > (the full tree is devel/xen-blkback-v3)
> > 
> > Please take a look at the patch. I know that I need to rewrite the description
> > to have more details for the upstream community - and that will be shortly supplied.
> > 
> > Any thoughts on what I should address/remove/augment/etc would be appreciated. And whether
> > the code has any obvious pitfalls?
> > 
> > The code was originally lifted from 2.6.18, then ported to 2.6.32, and now I have backported
> > it to 2.6.38/.39. scripts/checkpatch.pl had been applied and also some re-ordering of the code
> > has been done to make it easier to read.
> 
> If propose to consider eliminating vbd.c and interface.c, inlining the
> critical bits where they belong, respectively.

Ok. Let me take an axe to that.
> 
> Leaving only blkback.c for the data- and xenbus.c for the control path.

<nods>
> 
> I don't think there's anything notable in there which has more than a
> single position to call it from. It always looked like out of some
> abstraction layer to me, maybe with blktap1 in mind. Beyond that, I
> don't see that getting anywhere.
> 
> Daniel
>