xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: jaxboe@fusionio.com, xen-devel@lists.xensource.com,
	linux-kernel@vger.kernel.org, konrad@kernel.org
Subject: Re: [PATCH] xen block backend driver.
Date: Wed, 20 Apr 2011 23:40:16 -0400	[thread overview]
Message-ID: <20110421034016.GB11501@infradead.org> (raw)
In-Reply-To: <1303333543-5915-2-git-send-email-konrad.wilk@oracle.com>

> +#define WRITE_BARRIER	(REQ_WRITE | REQ_FLUSH | REQ_FUA)

Any in case you want to keep usingthis POS out of tree you really need
to fix this.  REQ_FLUSH | REQ_FUA is not equivalent to the old barrier
semantics that the Xen disk protocol exported to the guest.  You need
to drain the whole queue of outstanding I/Os as some old guest (at least
those using reiserfs, e.g. old SLES) rely on it.

  reply	other threads:[~2011-04-21  3:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-20 21:05 [PATCH v3] xen block backend Konrad Rzeszutek Wilk
2011-04-20 21:05 ` [PATCH] xen block backend driver Konrad Rzeszutek Wilk
2011-04-21  3:40   ` Christoph Hellwig [this message]
2011-04-21 19:03     ` [Xen-devel] " Daniel Stodden
2011-04-21 19:06       ` Christoph Hellwig
2011-04-21 19:14         ` [Xen-devel] " Daniel Stodden
2011-04-22  9:09           ` Christoph Hellwig
2011-05-02 19:08             ` [Xen-devel] Re: [PATCH] xen block backend driver. - proper flush/barrier/fua support missing Konrad Rzeszutek Wilk
2011-04-21  3:37 ` [PATCH v3] xen block backend Christoph Hellwig
2011-04-21  7:28   ` [Xen-devel] " Ian Campbell
2011-04-21  8:03     ` Ian Campbell
2011-04-21  8:06       ` Christoph Hellwig
2011-04-21  8:38         ` Ian Campbell
2011-04-21  8:04     ` [Xen-devel] " Christoph Hellwig
2011-04-27 22:06       ` Konrad Rzeszutek Wilk
2011-04-28 19:29         ` Pasi Kärkkäinen
  -- strict thread matches above, loose matches on Subject: below --
2011-05-05 18:11 [PATCH v3.1] " Konrad Rzeszutek Wilk
2011-05-05 18:11 ` [PATCH] xen block backend driver Konrad Rzeszutek Wilk
2011-05-11 15:02   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110421034016.GB11501@infradead.org \
    --to=hch@infradead.org \
    --cc=jaxboe@fusionio.com \
    --cc=konrad.wilk@oracle.com \
    --cc=konrad@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).