xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: RFC Patch for the "x86-64, mm: Put early page table high"
Date: Mon, 2 May 2011 10:03:30 -0400	[thread overview]
Message-ID: <20110502140330.GA13192@dumpdata.com> (raw)
In-Reply-To: <4DBB4DDD.3000703@goop.org>

> >>> So I decided to look at this from a different perspective: why not
> >>> contain the workaround inside Xen early bootup code.
> >>>
> >>> I've tested this code as DomU (1G, 2G, 3G), Dom0 (8G, 4G, 1000M)
> >>> and they all booted fine. Hadn't compile tested it on 32-bit and
> >>> I think it will actually complain about it. Let me fix that.
> >>>
> >>> See attached patch (also present in stable/bug-fixes-for-rc5) which also
> >>> has the "xen: mask_rw_pte mark RO all pagetable pages up to pgt_buf_top"
> >>> integrated in.
> >> Well, if we can hide the fix away in our code, then that has obvious
> >> advantages.  But I worry that this change is pretty closely dependent on
> >> how the other code works, and would be fragile in the face of further
> >> changes to that code (esp since there's no obvious coupling between the
> >> two, so anyone changing the arch/x86 code wouldn't have any clues to
> >> look at the corresponding Xen code).
> > True. I am hoping to remove this in 2.6.40 though...
> 
> That makes it more palatable.  What's the solution for 40+?

None yet. I am thinking to schedule some form of meeting between hpa, Yinghai,
Stefano, you, and whoever else to hammer something out.

So far we got two workarounds in the Xen MMU code - there is the 32-bit dance with
the swapper_pg being copied from initial_..something and then back (Ian came up
with a fix for that), and then this one.

Did you have a chance to test this patch on your box?

      reply	other threads:[~2011-05-02 14:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29 15:46 RFC Patch for the "x86-64, mm: Put early page table high" Konrad Rzeszutek Wilk
2011-04-29 20:58 ` Jeremy Fitzhardinge
2011-04-29 21:33   ` Konrad Rzeszutek Wilk
2011-04-29 22:38     ` Konrad Rzeszutek Wilk
2011-04-29 23:46     ` Jeremy Fitzhardinge
2011-05-02 14:03       ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110502140330.GA13192@dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=jeremy@goop.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).