From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: yinghai@kernel.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] Re: [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high'
Date: Mon, 2 May 2011 16:07:30 -0400 [thread overview]
Message-ID: <20110502200730.GA15557@dumpdata.com> (raw)
In-Reply-To: <4DBF0D0C.8000105@zytor.com>
On Mon, May 02, 2011 at 12:59:08PM -0700, H. Peter Anvin wrote:
> On 05/02/2011 12:34 PM, Konrad Rzeszutek Wilk wrote:
> > On Mon, May 02, 2011 at 11:33:16AM -0700, H. Peter Anvin wrote:
> >> On 05/02/2011 11:08 AM, Konrad Rzeszutek Wilk wrote:
> >>>>
> >>>> My inclination would be to apply your workaround -- are there any
> >>>> adverse effects to doing that?
> >>>
> >>> There is a bootup slowdown (not noticeable). That is because we call the
> >>> 'memblock_find_range' function on every PTE table creation (only during
> >>> bootup of course).
> >>>
> >>> Testing wise, on the machines on which the regression occurred, with these two
> >>> patches the regression disappears - so that is a good sign. I am testing
> >>> it on some more today to assure myself I am not missing anything.
> >>>
> >>
> >> OK, sounds like a plan then. I like it because it doesn't affect the
> >> native kernel.
> >
> > <laughs> I figured :-)
> >
> > Moving forward I really want to get rid of this wart.
> >
> > Not sure if it is possible, but I was thinking it would be nice to get
> > you, Yinghai, Jeremy, Stefano all in one place (phone or web-conference thing)
> > to sketch out some ideas and hammer something out.
> >
> > What days would work best?
>
> First things first... are you pushing the workaround (you can add my
> Acked-by:) or should I?
I will do it tomorrow and stick your Acked-by on both patches.
>
> Second... I don't know what physical locations and/or time zones every
> one is in, which is probably the first thing.
EST for me, Jeremy is PST (California), Stefano is in UK, so that is UTC+0, and
no idea where Yinghai is.
But people are on vacation time right now so or until next week, plus
> Third, I will be travelling a lot over the next two weeks, plus we are
.. you are traveling.
> getting close to merge window time, so it might be hard to schedule
> before the merge window. Are you looking at trying to push something
> for .40? If so, you probably should have an implementation in mind
> already. If not, I suggest we aim for after the merge window is over or
> at least quieted down.
.. and I don't have any implementation in mind yet. Was hoping we could
brainstorm something together.
OK, let me bug you guys when the merge window is over.
>
> -hpa
next prev parent reply other threads:[~2011-05-02 20:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 17:22 [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high' Konrad Rzeszutek Wilk
2011-05-02 17:22 ` [PATCH 1/2] xen/mmu: Add workaround "x86-64, mm: Put early page table high" Konrad Rzeszutek Wilk
2011-05-03 0:55 ` Daniel Kiper
2011-05-03 15:12 ` Konrad Rzeszutek Wilk
2011-05-03 19:51 ` Daniel Kiper
2011-05-04 18:59 ` Daniel Kiper
2011-05-04 19:33 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-05-05 11:34 ` Daniel Kiper
2011-05-05 12:55 ` Stefano Stabellini
2011-05-05 14:01 ` Konrad Rzeszutek Wilk
2011-05-05 14:06 ` Stefano Stabellini
2011-05-09 7:06 ` Daniel Kiper
2011-05-03 13:20 ` Stefano Stabellini
2011-05-03 15:27 ` Konrad Rzeszutek Wilk
2011-05-02 17:22 ` [PATCH 2/2] xen: mask_rw_pte mark RO all pagetable pages up to pgt_buf_top Konrad Rzeszutek Wilk
2011-05-02 17:31 ` [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high' H. Peter Anvin
2011-05-02 18:08 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-05-02 18:33 ` H. Peter Anvin
2011-05-02 19:34 ` Konrad Rzeszutek Wilk
2011-05-02 19:59 ` [Xen-devel] " H. Peter Anvin
2011-05-02 20:07 ` Konrad Rzeszutek Wilk [this message]
2011-05-02 20:16 ` Yinghai Lu
2011-05-05 16:28 ` Re: [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high' - does not work Konrad Rzeszutek Wilk
2011-05-05 18:45 ` [Xen-devel] " Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502200730.GA15557@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).