From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] Re: [PATCH] xen block backend driver. Date: Thu, 12 May 2011 17:01:52 -0400 Message-ID: <20110512210151.GA26497@dumpdata.com> References: <1304619093-22354-1-git-send-email-konrad.wilk@oracle.com> <1304619093-22354-2-git-send-email-konrad.wilk@oracle.com> <1305126132.26692.420.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1305126132.26692.420.camel@zakaz.uk.xensource.com> Sender: linux-kernel-owner@vger.kernel.org To: Ian Campbell Cc: "xen-devel@lists.xensource.com" , Stefano Stabellini , "jaxboe@fusionio.com" , "linux-kernel@vger.kernel.org" , "hch@infradead.org" List-Id: xen-devel@lists.xenproject.org On Wed, May 11, 2011 at 04:02:12PM +0100, Ian Campbell wrote: > On Thu, 2011-05-05 at 19:11 +0100, Konrad Rzeszutek Wilk wrote: > > This is the host side counterpart to the frontend driver > > in drivers/block/xen-blkfront.c. The PV protocol is also implemented by > > frontend drivers in other OSes too, such as the BSDs and even Windows. > > > > The patch is based on the driver from the xen.git pvops kernel tree but > > has been put through the checkpatch.pl wringer plus several manual > > cleanup passes. It has also been moved from drivers/xen/blkback to > > drivers/block/xen-blback. > > > > Signed-off-by: Konrad Rzeszutek Wilk > > Reviewed-by: Ian Campbell > > Not much to say below, mostly minor nits really. Thanks for reviewing it. I believe I've taken all your apt comments in consideration. Will post the v3.2 shortly. > > +/* > > + * Function to copy the from the ring buffer the 'struct blkif_request' > > Is the blkif namespace fair game? (I was asked to change netif is all) It is shared with the frontend driver. I can definitly change it but was thinking to do it once it is in the tree - that way it can be one patch for both of them without having to worry about carrying two branches for blkfront.