From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 2 of 3] libxl: Add support for passing in the machine's E820 for PCI passthrough Date: Tue, 17 May 2011 12:00:53 -0400 Message-ID: <20110517160053.GC3657@dumpdata.com> References: <19922.36862.514514.475625@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <19922.36862.514514.475625@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: Ian Campbell , "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Tue, May 17, 2011 at 04:10:54PM +0100, Ian Jackson wrote: > Sorry for the delay replying. But: > > Konrad Rzeszutek Wilk writes ("[PATCH 2 of 3] libxl: Add support for passing in the machine's E820 for PCI passthrough"): > > diff -r b6af9b428bb1 -r ba218fa1a48e tools/libxl/xl_cmdimpl.c > ... > > @@ -994,6 +995,8 @@ skip_vfb: > > if (!libxl_device_pci_parse_bdf(ctx, pcidev, buf)) > > d_config->num_pcidevs++; > > } > > + if (d_config->num_pcidevs && !c_info->hvm) > > + b_info->u.pv.machine_e820 = true; > > } > > This doesn't seem to provide a way to force this behaviour on, which > is (I assume) necessary if PCI devices are to be hotplugged later ? Right. We never resolved that question. One idea was that if you had 'pci=[]' it would trigger this. But that just seemed wrong.