From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 03 of 45] gcc-4.6 compile fix:
	tools/xenstore/xenstored_core.c
Date: Fri, 20 May 2011 16:38:46 +0200
Message-ID: <20110520143846.GA17222@aepfle.de>
References: <1305880225.20576.2.camel@zakaz.uk.xensource.com>
	<C9FBE7CE.2D7EC%keir@xen.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <C9FBE7CE.2D7EC%keir@xen.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir@xen.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, May 20, Keir Fraser wrote:

> On 20/05/2011 09:30, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:
> 
> >> I applied the first couple of these patches, but... We don't set
> >> -Werror=unused-but-set-variable, so we don't actually need these fixes, do
> >> we? Unless they are cleanups or fixes in some other way?
> > 
> > gcc 4.6 adds it to the default set of Werrors.
> 
> I'll take a patch from someone to remove it from the default set, please.

I will send a tested patch.

It may hide some bugs. In one of the patches for tools/ some function
returns 0 unconditionally instead of the rc variable.

Olaf