From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markus =?iso-8859-1?q?Gro=DF?= <gross@univention.de>
Subject: Re: libxc: correctly unmap pages after core-dumping a pv
	guest
Date: Mon, 23 May 2011 14:24:01 +0200
Message-ID: <201105231424.01099.gross@univention.de>
References: <201105231342.28471.gross@univention.de>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <201105231342.28471.gross@univention.de>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

I forgot to put [PATCH] in the subject, sorry about that.

Am Montag 23 Mai 2011 13:42:28 schrieb Markus Gro=DF:
> Hi,
>=20
> while implementing core dumping functionality for the libxl driver
> of libvirt, I discovered an issue with mapping pages of a pv guest.
>=20
> After dumping the core of a pv guest the domain was not cleared up
> properly and some pages were not unmapped. This issue is similar
> to the one reported here:
> http://lists.xensource.com/archives/html/xen-devel/2011-05/msg01314.html
>=20
> In xc_domain_dumpcore_via_callback in the file xc_core.c the function
> xc_core_arch_map_p2m is called to map P2M_FL_ENTRIES pages to the variabl=
e p2m.
> But to unmap the pages later, the dinfo->p2m_size has to be set according=
ly.
> This was not done, instead a variable named p2m_size was set.
> This way P2M_FL_ENTRIES was always zero and the pages were left mapped.
>=20
> The following patch fixes this.
>=20
> Best regards,
> Markus
> =20
> diff -r 7c7ef1b6f4e5 tools/libxc/xc_core.c
> --- a/tools/libxc/xc_core.c     Tue Apr 26 14:11:18 2011 +0100
> +++ b/tools/libxc/xc_core.c     Mon May 23 13:36:23 2011 +0200
> @@ -468,7 +468,6 @@
> =20
>      int auto_translated_physmap;
>      xen_pfn_t *p2m =3D NULL;
> -    unsigned long p2m_size =3D 0;
>      struct xen_dumpcore_p2m *p2m_array =3D NULL;
> =20
>      uint64_t *pfn_array =3D NULL;
> @@ -569,7 +568,7 @@
>          }
> =20
>          sts =3D xc_core_arch_map_p2m(xch, dinfo->guest_width, &info, liv=
e_shinfo,
> -                                   &p2m, &p2m_size);
> +                                   &p2m, &dinfo->p2m_size);
>          if ( sts !=3D 0 )
>              goto out;
>      }
>=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>=20