From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus =?utf-8?b?R3Jvw58=?= Subject: Re: libxc: correctly unmap pages after core-dumping a pv guest Date: Tue, 24 May 2011 18:22:55 +0200 Message-ID: <20110524182255.18755u24gwhgyd8g@mail.univention.de> References: <201105231342.28471.gross@univention.de> <19931.51607.411678.708897@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <19931.51607.411678.708897@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Quoting Ian Jackson : > Markus Gro=C3=9F writes ("[Xen-devel] libxc: correctly unmap pages after = =20 > core-dumping a pv guest"): >> But to unmap the pages later, the dinfo->p2m_size has to be set accordin= gly. >> This was not done, instead a variable named p2m_size was set. >> This way P2M_FL_ENTRIES was always zero and the pages were left mapped. >> >> The following patch fixes this. > > Thanks. The existing code here is pretty unfortunate. > > In xc_domain_dumpcore_via_callback where you make your change, "dinfo" > refers to a struct domain_info_context which is local to that > function. But in the called function xc_core_arch_map_p2m_rw, "dinfo" > refers to another identical structure allocated locally to the small > wrapper function xc_core_arch_map_p2m. All rather tangled. > > But, anyway, your change is correct so I have applied it. > > Next time, though, can you please be sure to add a Signed-off-by line, > to signify your certification in accordance with the Developer's > Certificate of Origin ? In this case I'll go ahead as it's only a > couple of lines. > > Thanks, > Ian. Thanks, although I did repost the patch with a Signed-off-by line here: http://lists.xensource.com/archives/html/xen-devel/2011-05/msg01469.html Cheers, Markus > > From Documentation/SubmittingPatches in the Linux kernel tree: > > Developer's Certificate of Origin 1.1 > > By making a contribution to this project, I certify that: > > (a) The contribution was created in whole or in part by me and I > have the right to submit it under the open source license > indicated in the file; or > > (b) The contribution is based upon previous work that, to the bes= t > of my knowledge, is covered under an appropriate open source > license and I have the right under that license to submit tha= t > work with modifications, whether created in whole or in part > by me, under the same open source license (unless I am > permitted to submit under a different license), as indicated > in the file; or > > (c) The contribution was provided directly to me by some other > person who certified (a), (b) or (c) and I have not modified > it. > > (d) I understand and agree that this project and the contribution > are public and that a record of the contribution (including a= ll > personal information I submit with it, including my sign-off)= is > maintained indefinitely and may be redistributed consistent w= ith > this project or the open source license(s) involved. >