From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <liuw@liuw.name>
Cc: xen-devel@lists.xensource.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 2/2] libxc: enabling emulated MSI injection
Date: Thu, 26 May 2011 09:05:56 -0400 [thread overview]
Message-ID: <20110526130556.GA26618@dumpdata.com> (raw)
In-Reply-To: <BANLkTimbENZYPabSHNQh08XA-OYEsJ3XkA@mail.gmail.com>
> >> + hypercall.op = __HYPERVISOR_hvm_op;
> >> + hypercall.arg[0] = HVMOP_inj_msi;
> >> + hypercall.arg[1] = HYPERCALL_BUFFER_AS_ARG(arg);
> >> +
> >> + arg->domid = dom;
> >> + arg->addr = addr;
> >> + arg->data = data;
> >
> > Shouldn't those be done before you make the HYPERCALL_BUFFER_AS_ARG
> > in case they get bounced?
> >
>
> Hmm... I didn't think that far.
>
> I just copy-and-edit from a previous hypercall. I think that should be OK then.
On a second look at the code, I believe you are right.
next prev parent reply other threads:[~2011-05-26 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 3:09 [PATCH 2/2] libxc: enabling emulated MSI injection Wei Liu
2011-05-26 12:34 ` Konrad Rzeszutek Wilk
2011-05-26 12:56 ` Wei Liu
2011-05-26 13:05 ` Konrad Rzeszutek Wilk [this message]
2011-05-26 12:59 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526130556.GA26618@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=liuw@liuw.name \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).