From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 2/2] libxc: enabling emulated MSI injection
Date: Thu, 26 May 2011 09:05:56 -0400
Message-ID: <20110526130556.GA26618@dumpdata.com>
References: <BANLkTi=PDEZzOOXsmzYVfuCnNf9uaOt_EQ@mail.gmail.com>
	<20110526123452.GA3386@dumpdata.com>
	<BANLkTimbENZYPabSHNQh08XA-OYEsJ3XkA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <BANLkTimbENZYPabSHNQh08XA-OYEsJ3XkA@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Wei Liu <liuw@liuw.name>
Cc: xen-devel@lists.xensource.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

> >> + =A0 =A0hypercall.op =A0 =A0 =3D __HYPERVISOR_hvm_op;
> >> + =A0 =A0hypercall.arg[0] =3D HVMOP_inj_msi;
> >> + =A0 =A0hypercall.arg[1] =3D HYPERCALL_BUFFER_AS_ARG(arg);
> >> +
> >> + =A0 =A0arg->domid =3D dom;
> >> + =A0 =A0arg->addr =A0=3D addr;
> >> + =A0 =A0arg->data =A0=3D data;
> >
> > Shouldn't those be done before you make the HYPERCALL_BUFFER_AS_ARG
> > in case they get bounced?
> >
>=20
> Hmm... I didn't think that far.
>=20
> I just copy-and-edit from a previous hypercall. I think that should be =
OK then.

On a second look at the code, I believe you are right.