* [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc [not found] <cover.1306603968.git.joe@perches.com> @ 2011-05-28 17:36 ` Joe Perches 2011-05-28 17:48 ` Heiko Stübner 2011-05-30 11:40 ` [TRIVIAL PATCH " Mel Gorman 0 siblings, 2 replies; 6+ messages in thread From: Joe Perches @ 2011-05-28 17:36 UTC (permalink / raw) To: Jaya Kumar, Paul Mundt, Jeremy Fitzhardinge, Konrad Rzeszutek Wilk Cc: linux-fbdev, xen-devel, linux-kernel, virtualization Signed-off-by: Joe Perches <joe@perches.com> --- drivers/video/arcfb.c | 5 ++--- drivers/video/broadsheetfb.c | 4 +--- drivers/video/hecubafb.c | 5 ++--- drivers/video/metronomefb.c | 4 +--- drivers/video/xen-fbfront.c | 3 +-- 5 files changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c index 3ec4923..86573e2 100644 --- a/drivers/video/arcfb.c +++ b/drivers/video/arcfb.c @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct platform_device *dev) /* We need a flat backing store for the Arc's less-flat actual paged framebuffer */ - if (!(videomemory = vmalloc(videomemorysize))) + videomemory = vmalloc(videomemorysize); + if (!videomemory) return retval; - memset(videomemory, 0, videomemorysize); - info = framebuffer_alloc(sizeof(struct arcfb_par), &dev->dev); if (!info) goto err; diff --git a/drivers/video/broadsheetfb.c b/drivers/video/broadsheetfb.c index ebda687..377dde3 100644 --- a/drivers/video/broadsheetfb.c +++ b/drivers/video/broadsheetfb.c @@ -1101,12 +1101,10 @@ static int __devinit broadsheetfb_probe(struct platform_device *dev) videomemorysize = roundup((dpyw*dpyh), PAGE_SIZE); - videomemory = vmalloc(videomemorysize); + videomemory = vzalloc(videomemorysize); if (!videomemory) goto err_fb_rel; - memset(videomemory, 0, videomemorysize); - info->screen_base = (char *)videomemory; info->fbops = &broadsheetfb_ops; diff --git a/drivers/video/hecubafb.c b/drivers/video/hecubafb.c index 1b94643..fbef15f 100644 --- a/drivers/video/hecubafb.c +++ b/drivers/video/hecubafb.c @@ -231,11 +231,10 @@ static int __devinit hecubafb_probe(struct platform_device *dev) videomemorysize = (DPY_W*DPY_H)/8; - if (!(videomemory = vmalloc(videomemorysize))) + videomemory = vzalloc(videomemorysize); + if (!videomemory) return retval; - memset(videomemory, 0, videomemorysize); - info = framebuffer_alloc(sizeof(struct hecubafb_par), &dev->dev); if (!info) goto err_fballoc; diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c index ed64edf..97d45e5 100644 --- a/drivers/video/metronomefb.c +++ b/drivers/video/metronomefb.c @@ -628,12 +628,10 @@ static int __devinit metronomefb_probe(struct platform_device *dev) /* we need to add a spare page because our csum caching scheme walks * to the end of the page */ videomemorysize = PAGE_SIZE + (fw * fh); - videomemory = vmalloc(videomemorysize); + videomemory = vzalloc(videomemorysize); if (!videomemory) goto err_fb_rel; - memset(videomemory, 0, videomemorysize); - info->screen_base = (char __force __iomem *)videomemory; info->fbops = &metronomefb_ops; diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c index a20218c..beac52f 100644 --- a/drivers/video/xen-fbfront.c +++ b/drivers/video/xen-fbfront.c @@ -395,10 +395,9 @@ static int __devinit xenfb_probe(struct xenbus_device *dev, spin_lock_init(&info->dirty_lock); spin_lock_init(&info->resize_lock); - info->fb = vmalloc(fb_size); + info->fb = vzalloc(fb_size); if (info->fb == NULL) goto error_nomem; - memset(info->fb, 0, fb_size); info->nr_pages = (fb_size + PAGE_SIZE - 1) >> PAGE_SHIFT; -- 1.7.5.rc3.dirty ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc 2011-05-28 17:36 ` [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc Joe Perches @ 2011-05-28 17:48 ` Heiko Stübner 2011-05-28 18:13 ` [TRIVIAL PATCH V2 " Joe Perches 2011-05-30 11:40 ` [TRIVIAL PATCH " Mel Gorman 1 sibling, 1 reply; 6+ messages in thread From: Heiko Stübner @ 2011-05-28 17:48 UTC (permalink / raw) To: Joe Perches Cc: Jaya Kumar, Paul Mundt, Jeremy Fitzhardinge, Konrad Rzeszutek Wilk, Jiri Kosina, linux-fbdev, linux-kernel, xen-devel, virtualization Am Samstag 28 Mai 2011, 19:36:32 schrieb Joe Perches: > diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c > index 3ec4923..86573e2 100644 > --- a/drivers/video/arcfb.c > +++ b/drivers/video/arcfb.c > @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct > platform_device *dev) > > /* We need a flat backing store for the Arc's > less-flat actual paged framebuffer */ > - if (!(videomemory = vmalloc(videomemorysize))) > + videomemory = vmalloc(videomemorysize); > + if (!videomemory) > return retval; shouldn't this be vzalloc too? > - memset(videomemory, 0, videomemorysize); > - > info = framebuffer_alloc(sizeof(struct arcfb_par), &dev->dev); > if (!info) > goto err; Heiko ^ permalink raw reply [flat|nested] 6+ messages in thread
* [TRIVIAL PATCH V2 next 12/15] video: Convert vmalloc/memset to vzalloc 2011-05-28 17:48 ` Heiko Stübner @ 2011-05-28 18:13 ` Joe Perches 2011-05-31 14:28 ` Konrad Rzeszutek Wilk 2011-06-02 8:26 ` Paul Mundt 0 siblings, 2 replies; 6+ messages in thread From: Joe Perches @ 2011-05-28 18:13 UTC (permalink / raw) To: Heiko Stübner Cc: Jaya Kumar, Paul Mundt, Jeremy Fitzhardinge, Konrad Rzeszutek Wilk, Jiri Kosina, linux-fbdev, linux-kernel, xen-devel, virtualization Signed-off-by: Joe Perches <joe@perches.com> --- Heiko Stübner <heiko@sntech.de> pointed out I can't type... s/vmalloc/vmalloc/ doesn't do much. drivers/video/arcfb.c | 5 ++--- drivers/video/broadsheetfb.c | 4 +--- drivers/video/hecubafb.c | 5 ++--- drivers/video/metronomefb.c | 4 +--- drivers/video/xen-fbfront.c | 3 +-- 5 files changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c index 3ec4923..86573e2 100644 --- a/drivers/video/arcfb.c +++ b/drivers/video/arcfb.c @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct platform_device *dev) /* We need a flat backing store for the Arc's less-flat actual paged framebuffer */ - if (!(videomemory = vmalloc(videomemorysize))) + videomemory = vzalloc(videomemorysize); + if (!videomemory) return retval; - memset(videomemory, 0, videomemorysize); - info = framebuffer_alloc(sizeof(struct arcfb_par), &dev->dev); if (!info) goto err; diff --git a/drivers/video/broadsheetfb.c b/drivers/video/broadsheetfb.c index ebda687..377dde3 100644 --- a/drivers/video/broadsheetfb.c +++ b/drivers/video/broadsheetfb.c @@ -1101,12 +1101,10 @@ static int __devinit broadsheetfb_probe(struct platform_device *dev) videomemorysize = roundup((dpyw*dpyh), PAGE_SIZE); - videomemory = vmalloc(videomemorysize); + videomemory = vzalloc(videomemorysize); if (!videomemory) goto err_fb_rel; - memset(videomemory, 0, videomemorysize); - info->screen_base = (char *)videomemory; info->fbops = &broadsheetfb_ops; diff --git a/drivers/video/hecubafb.c b/drivers/video/hecubafb.c index 1b94643..fbef15f 100644 --- a/drivers/video/hecubafb.c +++ b/drivers/video/hecubafb.c @@ -231,11 +231,10 @@ static int __devinit hecubafb_probe(struct platform_device *dev) videomemorysize = (DPY_W*DPY_H)/8; - if (!(videomemory = vmalloc(videomemorysize))) + videomemory = vzalloc(videomemorysize); + if (!videomemory) return retval; - memset(videomemory, 0, videomemorysize); - info = framebuffer_alloc(sizeof(struct hecubafb_par), &dev->dev); if (!info) goto err_fballoc; diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c index ed64edf..97d45e5 100644 --- a/drivers/video/metronomefb.c +++ b/drivers/video/metronomefb.c @@ -628,12 +628,10 @@ static int __devinit metronomefb_probe(struct platform_device *dev) /* we need to add a spare page because our csum caching scheme walks * to the end of the page */ videomemorysize = PAGE_SIZE + (fw * fh); - videomemory = vmalloc(videomemorysize); + videomemory = vzalloc(videomemorysize); if (!videomemory) goto err_fb_rel; - memset(videomemory, 0, videomemorysize); - info->screen_base = (char __force __iomem *)videomemory; info->fbops = &metronomefb_ops; diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c index a20218c..beac52f 100644 --- a/drivers/video/xen-fbfront.c +++ b/drivers/video/xen-fbfront.c @@ -395,10 +395,9 @@ static int __devinit xenfb_probe(struct xenbus_device *dev, spin_lock_init(&info->dirty_lock); spin_lock_init(&info->resize_lock); - info->fb = vmalloc(fb_size); + info->fb = vzalloc(fb_size); if (info->fb == NULL) goto error_nomem; - memset(info->fb, 0, fb_size); info->nr_pages = (fb_size + PAGE_SIZE - 1) >> PAGE_SHIFT; -- ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [TRIVIAL PATCH V2 next 12/15] video: Convert vmalloc/memset to vzalloc 2011-05-28 18:13 ` [TRIVIAL PATCH V2 " Joe Perches @ 2011-05-31 14:28 ` Konrad Rzeszutek Wilk 2011-06-02 8:26 ` Paul Mundt 1 sibling, 0 replies; 6+ messages in thread From: Konrad Rzeszutek Wilk @ 2011-05-31 14:28 UTC (permalink / raw) To: Joe Perches Cc: linux-fbdev, Jeremy Fitzhardinge, Jiri Kosina, Heiko Stübner, linux-kernel, virtualization, Paul Mundt, xen-devel, Jaya Kumar On Sat, May 28, 2011 at 11:13:33AM -0700, Joe Perches wrote: > Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> on the: > diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c > index a20218c..beac52f 100644 > --- a/drivers/video/xen-fbfront.c > +++ b/drivers/video/xen-fbfront.c > @@ -395,10 +395,9 @@ static int __devinit xenfb_probe(struct xenbus_device *dev, > spin_lock_init(&info->dirty_lock); > spin_lock_init(&info->resize_lock); > > - info->fb = vmalloc(fb_size); > + info->fb = vzalloc(fb_size); > if (info->fb == NULL) > goto error_nomem; > - memset(info->fb, 0, fb_size); > > info->nr_pages = (fb_size + PAGE_SIZE - 1) >> PAGE_SHIFT; ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [TRIVIAL PATCH V2 next 12/15] video: Convert vmalloc/memset to vzalloc 2011-05-28 18:13 ` [TRIVIAL PATCH V2 " Joe Perches 2011-05-31 14:28 ` Konrad Rzeszutek Wilk @ 2011-06-02 8:26 ` Paul Mundt 1 sibling, 0 replies; 6+ messages in thread From: Paul Mundt @ 2011-06-02 8:26 UTC (permalink / raw) To: Joe Perches Cc: Heiko St?bner, Jaya Kumar, Jeremy Fitzhardinge, Konrad Rzeszutek Wilk, Jiri Kosina, linux-fbdev, linux-kernel, xen-devel, virtualization On Sat, May 28, 2011 at 11:13:33AM -0700, Joe Perches wrote: > Signed-off-by: Joe Perches <joe@perches.com> > --- > Heiko St??bner <heiko@sntech.de> pointed out I can't type... > s/vmalloc/vmalloc/ doesn't do much. > > drivers/video/arcfb.c | 5 ++--- > drivers/video/broadsheetfb.c | 4 +--- > drivers/video/hecubafb.c | 5 ++--- > drivers/video/metronomefb.c | 4 +--- > drivers/video/xen-fbfront.c | 3 +-- > 5 files changed, 7 insertions(+), 14 deletions(-) > v2 applied. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc 2011-05-28 17:36 ` [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc Joe Perches 2011-05-28 17:48 ` Heiko Stübner @ 2011-05-30 11:40 ` Mel Gorman 1 sibling, 0 replies; 6+ messages in thread From: Mel Gorman @ 2011-05-30 11:40 UTC (permalink / raw) To: Joe Perches Cc: Jaya Kumar, Paul Mundt, Jeremy Fitzhardinge, Konrad Rzeszutek Wilk, Jiri Kosina, linux-fbdev, xen-devel, linux-kernel, virtualization On Sat, May 28, 2011 at 10:36:32AM -0700, Joe Perches wrote: > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/video/arcfb.c | 5 ++--- > drivers/video/broadsheetfb.c | 4 +--- > drivers/video/hecubafb.c | 5 ++--- > drivers/video/metronomefb.c | 4 +--- > drivers/video/xen-fbfront.c | 3 +-- > 5 files changed, 7 insertions(+), 14 deletions(-) > > diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c > index 3ec4923..86573e2 100644 > --- a/drivers/video/arcfb.c > +++ b/drivers/video/arcfb.c > @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct platform_device *dev) > > /* We need a flat backing store for the Arc's > less-flat actual paged framebuffer */ > - if (!(videomemory = vmalloc(videomemorysize))) > + videomemory = vmalloc(videomemorysize); > + if (!videomemory) > return retval; > > - memset(videomemory, 0, videomemorysize); > - > info = framebuffer_alloc(sizeof(struct arcfb_par), &dev->dev); > if (!info) > goto err; This is the first commit I saw and stopped reading at this point because this hunk is not using vzalloc. I imagine grep for ^+ and vmalloc throughout the series would be helpful? -- Mel Gorman SUSE Labs ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-02 8:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1306603968.git.joe@perches.com>
2011-05-28 17:36 ` [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc Joe Perches
2011-05-28 17:48 ` Heiko Stübner
2011-05-28 18:13 ` [TRIVIAL PATCH V2 " Joe Perches
2011-05-31 14:28 ` Konrad Rzeszutek Wilk
2011-06-02 8:26 ` Paul Mundt
2011-05-30 11:40 ` [TRIVIAL PATCH " Mel Gorman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).