From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] Re: [patch] xen: off by one errors in multicalls.c Date: Fri, 3 Jun 2011 15:57:15 -0400 Message-ID: <20110603195715.GB30940@dumpdata.com> References: <20110603044528.GD3661@shale.localdomain> <4DE926D4.9010009@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4DE926D4.9010009@goop.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jeremy Fitzhardinge Cc: "open list:XEN HYPERVISOR IN..." , Dan Carpenter , "maintainer:X86 ARCHITECTURE..." , kernel-janitors@vger.kernel.org, "open list:XEN HYPERVISOR IN..." , Jeremy Fitzhardinge , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar List-Id: xen-devel@lists.xenproject.org On Fri, Jun 03, 2011 at 11:24:20AM -0700, Jeremy Fitzhardinge wrote: > On 06/02/2011 09:45 PM, Dan Carpenter wrote: > > b->args[] has MC_ARGS elements, so the comparison here should be > > ">=" instead of ">". Otherwise we read past the end of the array > > one space. > > Yeah, looks like a correct fix. Fortunately I don't think anything > currently hits that path in practice, though there are some pending > patches which will exercise it more. OK, queueing it for rc1.