* [PATCH] nestedhvm: avoid endless loop of nested page faults
@ 2011-08-19 12:02 Christoph Egger
2011-08-19 12:46 ` Tim Deegan
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Egger @ 2011-08-19 12:02 UTC (permalink / raw)
To: xen-devel@lists.xensource.com, Tim Deegan
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
Stop sending IPIs to flush the nested-on-nested pagetable
after write operations. Instead flush the TLB only.
This fixes an endless loop of nested page faults after
adding an entry to the nested-on-nested pagetable.
Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
[-- Attachment #2: xen_nh_ipi.diff --]
[-- Type: text/plain, Size: 479 bytes --]
diff -r ce4768a78051 xen/arch/x86/mm/hap/nested_hap.c
--- a/xen/arch/x86/mm/hap/nested_hap.c Mon Aug 08 11:36:21 2011 +0200
+++ b/xen/arch/x86/mm/hap/nested_hap.c Fri Aug 19 13:28:20 2011 +0200
@@ -86,8 +86,9 @@ nestedp2m_write_p2m_entry(struct p2m_dom
old_flags = l1e_get_flags(*p);
safe_write_pte(p, new);
+
if (old_flags & _PAGE_PRESENT)
- nestedhvm_vmcx_flushtlb(p2m);
+ flush_tlb_mask(&p2m->p2m_dirty_cpumask);
paging_unlock(d);
}
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nestedhvm: avoid endless loop of nested page faults
2011-08-19 12:02 [PATCH] nestedhvm: avoid endless loop of nested page faults Christoph Egger
@ 2011-08-19 12:46 ` Tim Deegan
0 siblings, 0 replies; 2+ messages in thread
From: Tim Deegan @ 2011-08-19 12:46 UTC (permalink / raw)
To: Christoph Egger; +Cc: xen-devel@lists.xensource.com, Tim Deegan
At 14:02 +0200 on 19 Aug (1313762545), Christoph Egger wrote:
> Stop sending IPIs to flush the nested-on-nested pagetable
> after write operations. Instead flush the TLB only.
> This fixes an endless loop of nested page faults after
> adding an entry to the nested-on-nested pagetable.
>
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
Applied, thanks.
Tim.
--
Tim Deegan <tim@xen.org>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-19 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-19 12:02 [PATCH] nestedhvm: avoid endless loop of nested page faults Christoph Egger
2011-08-19 12:46 ` Tim Deegan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).