From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Pasi Kärkkäinen" <pasik@iki.fi>
Cc: xen-devel@lists.xensource.com, JBeulich@novell.com,
owen.smith@citrix.com, Li Dongyang <lidongyang@novell.com>
Subject: Re: [PATCH V3 0/3] xen-blkfront/xen-blkback trim support
Date: Fri, 26 Aug 2011 13:10:48 -0400 [thread overview]
Message-ID: <20110826171048.GB2343@dumpdata.com> (raw)
In-Reply-To: <20110824141754.GZ32373@reaktio.net>
On Wed, Aug 24, 2011 at 05:17:54PM +0300, Pasi Kärkkäinen wrote:
> On Wed, Aug 24, 2011 at 05:23:42PM +0800, Li Dongyang wrote:
> > Dear list,
> > this is the V3 of the trim support for xen-blkfront/blkback,
>
> Isn't the generic name for this functionality "discard" in Linux?
>
> and "trim" being the ATA specific discard-implementation,
> and "scsi unmap" the SAS/SCSI specific discard-implementation?
Yeah. I think you are right. The 'feature-discard' sounds much much
more generic than the 'trim'. Since we are still implementing this
and I think we can take the liberty of making it 'feature-discard'.
Albeit it would mean that the Citrix folks would have to rewrite
their drivers.
>
> Just wondering..
>
> -- Pasi
>
> > thanks for all your reviews.
> > and when I looked back at Owen's patch in Dec 2010,
> > http://lists.xensource.com/archives/html/xen-devel/2010-12/msg00299.html
> > this patch above also add the trim union to blkif_x86_{32|64}_request,
> > and take care of trim request in blkif_get_x86{32|64}_req(),
> > however, in the later versions, the part is just gone. I wonder if it is
> > needed here? Thanks.
> >
> > Changelog V3:
> > rebased on linus's tree
> > enum backend types in blkif instead of flags in the interface header
> > more reasonable names in xenstore
> > move trim requesting handling to a separate function
> > do not re-enable interrupts unconditionally when handling response
> > set info->feature-trim only when we have all info needed for request queue
> > Changelog V2:
> > rebased on Jeremy's tree
> > fixes according to Jan Beulich's comments
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-08-26 17:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 9:23 [PATCH V3 0/3] xen-blkfront/xen-blkback trim support Li Dongyang
2011-08-24 9:23 ` [PATCH V3 1/3] xen-blkback: add BLKIF_OP_TRIM and backend types Li Dongyang
2011-08-24 10:26 ` Jan Beulich
[not found] ` <4E54EE080200007800052DEC@victor.provo.novell.com>
2011-08-25 6:34 ` Li Dongyang
2011-08-25 7:00 ` Jan Beulich
2011-08-24 9:23 ` [PATCH V3 2/3] xen-blkfront: teach blkfront driver handle trim request Li Dongyang
2011-08-24 10:42 ` Jan Beulich
[not found] ` <4E54F1C20200007800052DF8@victor.provo.novell.com>
2011-08-25 6:37 ` Li Dongyang
2011-08-25 7:03 ` Jan Beulich
2011-08-24 9:23 ` [PATCH V3 3/3] xen-blkback: handle trim request in backend driver Li Dongyang
2011-08-26 17:18 ` Konrad Rzeszutek Wilk
2011-08-24 14:17 ` [PATCH V3 0/3] xen-blkfront/xen-blkback trim support Pasi Kärkkäinen
2011-08-26 17:10 ` Konrad Rzeszutek Wilk [this message]
2011-08-29 7:47 ` Li Dongyang
2011-08-29 15:32 ` Konrad Rzeszutek Wilk
2011-08-26 16:56 ` Konrad Rzeszutek Wilk
2011-08-29 7:50 ` Li Dongyang
2011-08-29 15:31 ` Konrad Rzeszutek Wilk
2011-08-31 9:41 ` Li Dongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826171048.GB2343@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@novell.com \
--cc=lidongyang@novell.com \
--cc=owen.smith@citrix.com \
--cc=pasik@iki.fi \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).