From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Li Dongyang <lidongyang@novell.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
keir@xen.org
Cc: xen-devel@lists.xensource.com, owen.smith@citrix.com,
JBeulich@novell.com
Subject: Re: [PATCH V3 0/3] xen-blkfront/xen-blkback trim support
Date: Mon, 29 Aug 2011 11:32:12 -0400 [thread overview]
Message-ID: <20110829153212.GB11489@dumpdata.com> (raw)
In-Reply-To: <CAKH3R49tSR9B9jsa=-q-jTOEeK+4B4e0mvGT-PrqGEb41PHWSA@mail.gmail.com>
On Mon, Aug 29, 2011 at 03:47:37PM +0800, Li Dongyang wrote:
> On Sat, Aug 27, 2011 at 1:10 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> > On Wed, Aug 24, 2011 at 05:17:54PM +0300, Pasi Kärkkäinen wrote:
> >> On Wed, Aug 24, 2011 at 05:23:42PM +0800, Li Dongyang wrote:
> >> > Dear list,
> >> > this is the V3 of the trim support for xen-blkfront/blkback,
> >>
> >> Isn't the generic name for this functionality "discard" in Linux?
> >
> >>
> >> and "trim" being the ATA specific discard-implementation,
> >> and "scsi unmap" the SAS/SCSI specific discard-implementation?
> >
> > Yeah. I think you are right. The 'feature-discard' sounds much much
> > more generic than the 'trim'. Since we are still implementing this
> > and I think we can take the liberty of making it 'feature-discard'.
> yeah, that's why I use "feature-discard" in the patch at the first time.
> but since the header has already BLKIF_OP_TRIM so I changed that in
> later versions.
> and agree with u feature-discard makes more sense, maybe we also need to rename
> BLKIF_OP_TRIM to BLKIF_OP_DISCARD?
Lets get Keir and Ian's input on this.
next prev parent reply other threads:[~2011-08-29 15:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 9:23 [PATCH V3 0/3] xen-blkfront/xen-blkback trim support Li Dongyang
2011-08-24 9:23 ` [PATCH V3 1/3] xen-blkback: add BLKIF_OP_TRIM and backend types Li Dongyang
2011-08-24 10:26 ` Jan Beulich
[not found] ` <4E54EE080200007800052DEC@victor.provo.novell.com>
2011-08-25 6:34 ` Li Dongyang
2011-08-25 7:00 ` Jan Beulich
2011-08-24 9:23 ` [PATCH V3 2/3] xen-blkfront: teach blkfront driver handle trim request Li Dongyang
2011-08-24 10:42 ` Jan Beulich
[not found] ` <4E54F1C20200007800052DF8@victor.provo.novell.com>
2011-08-25 6:37 ` Li Dongyang
2011-08-25 7:03 ` Jan Beulich
2011-08-24 9:23 ` [PATCH V3 3/3] xen-blkback: handle trim request in backend driver Li Dongyang
2011-08-26 17:18 ` Konrad Rzeszutek Wilk
2011-08-24 14:17 ` [PATCH V3 0/3] xen-blkfront/xen-blkback trim support Pasi Kärkkäinen
2011-08-26 17:10 ` Konrad Rzeszutek Wilk
2011-08-29 7:47 ` Li Dongyang
2011-08-29 15:32 ` Konrad Rzeszutek Wilk [this message]
2011-08-26 16:56 ` Konrad Rzeszutek Wilk
2011-08-29 7:50 ` Li Dongyang
2011-08-29 15:31 ` Konrad Rzeszutek Wilk
2011-08-31 9:41 ` Li Dongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110829153212.GB11489@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=JBeulich@novell.com \
--cc=keir@xen.org \
--cc=lidongyang@novell.com \
--cc=owen.smith@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).