From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Li Dongyang <lidongyang@novell.com>
Cc: xen-devel@lists.xensource.com, owen.smith@citrix.com,
JBeulich@novell.com
Subject: Re: [PATCH V4 3/3] xen-blkback: discard requests handling in blkback driver
Date: Thu, 1 Sep 2011 11:28:26 -0400 [thread overview]
Message-ID: <20110901152826.GB6965@dumpdata.com> (raw)
In-Reply-To: <7f85bb71f76deed2537438928fa8b6dafb6a51f8.1314872306.git.lidongyang@novell.com>
On Thu, Sep 01, 2011 at 06:39:10PM +0800, Li Dongyang wrote:
> Now blkback driver can handle the discard request from guest, we will
> forward the request to phy device if it really has discard support, or we'll
> punch a hole on the image file.
The description should read:
xen-blkback: Implement discard requests handling
If the backend device (or loopback file) supports discard requests then
advertise it to the frontend via 'feature-discard'.
Implementation wise - if the backend is 'phy' - use blkdev_issue_discard,
while if it is 'file', then punch a hole in the image file.
Signed-off-by: Li Dongyang <lidongyang@novell.com>
.. snip..
> + if (err == -EOPNOTSUPP) {
> + pr_debug(DRV_PFX "blkback: discard op failed, "
^^^^^^^ - get rid of that.
The DRV_PFX already provides the 'xen-blkback' string.
prev parent reply other threads:[~2011-09-01 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 10:39 [PATCH V4 0/3] xen-blkfront/blkback discard support Li Dongyang
2011-09-01 10:39 ` [PATCH V4 1/3] xen-blkfront: add BLKIF_OP_DISCARD and discard request struct Li Dongyang
2011-09-01 10:39 ` [PATCH V4 2/3] xen-blkfront: teach blkfront driver to handle discard requests Li Dongyang
2011-09-01 15:25 ` Konrad Rzeszutek Wilk
2011-09-02 6:30 ` Li Dongyang
2011-09-02 13:28 ` Konrad Rzeszutek Wilk
2011-09-13 8:33 ` Li Dongyang
2011-09-13 13:15 ` Konrad Rzeszutek Wilk
2011-09-01 10:39 ` [PATCH V4 3/3] xen-blkback: discard requests handling in blkback driver Li Dongyang
2011-09-01 15:28 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901152826.GB6965@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@novell.com \
--cc=lidongyang@novell.com \
--cc=owen.smith@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).