From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 2 of 2] mem_event: use different ringbuffers for share, paging and access Date: Wed, 7 Sep 2011 15:55:19 +0100 Message-ID: <20110907145519.GF41585@ocelot.phlegethon.org> References: <9b0929f3243ced27c7c3.1315397730@probook.site> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Return-path: Content-Disposition: inline In-Reply-To: <9b0929f3243ced27c7c3.1315397730@probook.site> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Olaf Hering Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hi, At 14:15 +0200 on 07 Sep (1315404930), Olaf Hering wrote: > mem_event: use different ringbuffers for share, paging and access > > Up to now a single ring buffer was used for mem_share, xenpaging and > xen-access. Each helper would have to cooperate and pull only its own > requests from the ring. Unfortunately this was not implemented. And > even if it was, it would make the whole concept fragile because a crash > or early exit of one helper would stall the others. > > What happend up to now is that active xenpaging + memory_sharing would > push memsharing requests in the buffer. xenpaging is not prepared for > such requests. > > This patch creates an independet ring buffer for mem_share, xenpaging > and xen-access and adds also new functions to enable xenpaging and > xen-access. The xc_mem_event_enable/xc_mem_event_disable functions will > be removed. The various XEN_DOMCTL_MEM_EVENT_* macros were cleaned up. > Due to the removal the API changed, so the SONAME will be changed too. The Xen-side changes look OK to me. I'll leave it to the tools maintainers to comment on changing the libxc interface and version. Cheers, Tim.