From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking Date: Wed, 14 Sep 2011 21:34:37 +0200 Message-ID: <20110914193437.GX7761@one.firstfloor.org> References: <20110907165203.GQ6838@redhat.com> <4E67A551.4000502@redhat.com> <20110913184044.GN5795@redhat.com> <20110913190320.GR7761@one.firstfloor.org> <20110913192152.GO5795@redhat.com> <4E7050F7.3000208@redhat.com> <20110914144926.GU7761@one.firstfloor.org> <4E70C1BE.7060209@redhat.com> <20110914172838.GV7761@one.firstfloor.org> <4E70FFDD.80405@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4E70FFDD.80405@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Avi Kivity Cc: Don Zickus , Jeremy Fitzhardinge , Marcelo Tosatti , Nick Piggin , KVM , Stefano Stabellini , Peter Zijlstra , the arch/x86 maintainers , Linux Kernel Mailing List , Andi Kleen , Jeremy Fitzhardinge , "H. Peter Anvin" , Ingo Molnar , Linus Torvalds , Xen Devel List-Id: xen-devel@lists.xenproject.org On Wed, Sep 14, 2011 at 10:26:21PM +0300, Avi Kivity wrote: > On 09/14/2011 08:28 PM, Andi Kleen wrote: > >> If an NMI hits in an interrupt handler, or in the "after hlt" section > >> before the write-to-last-nmi-rip, then we'll see that %rip has changed. > >> If it hits after the write-to-last-nmi-rip instruction (or in the hlt > >> itself), then we'll also see that %rip has changed, due to the effect of > >> that instruction. > > > >It won't handle multiple NMIs in halt. I assume that's reasonable common. > > > > Why not? They all have the same original RIPs and there is no way to distingush them. -Andi -- ak@linux.intel.com -- Speaking for myself only.