From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH] remove blocked time accounting from xen
	"clockchip"
Date: Wed, 26 Oct 2011 16:52:43 -0400
Message-ID: <20111026205243.GA11095@phenom.dumpdata.com>
References: <1318970579-6282-1-git-send-email-lersek@redhat.com>
	<4E9E9D97020000780005C1DE@nat28.tlf.novell.com>
	<4EA031B0.2010400@redhat.com> <4EA03811.5090502@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <4EA03811.5090502@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Laszlo Ersek <lersek@redhat.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>, xen-devel@lists.xensource.com, Joe Jin <joe.jin@oracle.com>, Zhenzhong Duan <zhenzhong.duan@oracle.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, Oct 20, 2011 at 05:02:41PM +0200, Laszlo Ersek wrote:
> On 10/20/11 16:35, Laszlo Ersek wrote:
> 
> >I'm convinced the patch is correct, and only the commit message might
> >need a small fix (mentioning cpu_idle()).

Hey Laszlo and Zhenzhong,

Rest assured - I haven't forgotten about the two time patches.. little
busy with some of the Fedore Core 16 kernel bugs.

> 
> I forgot to say that I also added counters to xen_timer_interrupt(),
> account_idle_ticks() (called from cpu_idle()), and the idle time
> branch of account_process_tick(). (The last one is reached from
> xen_timer_interrupt() via event_handler == &tick_nohz_handler, after
> highres=off was passed). When the VM was left alone, they were
> increasing in strict lock-step.
> 
> account_idle_time()
> 
>   <- account_idle_ticks()
>     <- tick_nohz_restart_sched_tick()
>       <- cpu_idle()
> 
>   <- account_process_tick()
>     <- update_process_times()
>       <- tick_nohz_handler() [highres=off]
>         <- xen_timer_interrupt()
> 
>       <- (tick_periodic())
>       <- (tick_sched_timer())
> 
> The timer interrupt appears to kick cpu_idle(), and the latter
> accounts for the time spent idly.
> 
> Laszlo
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel