From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: olaf@aepfle.de, netdev@vger.kernel.org,
xen-devel@lists.xensource.com, jeremy.fitzhardinge@citrix.com,
konrad.wilk@oracle.com
Subject: Re: [PATCH] xen-netfront: report link speed to ethtool
Date: Fri, 18 Nov 2011 14:11:49 -0500 (EST) [thread overview]
Message-ID: <20111118.141149.231957666935653299.davem@davemloft.net> (raw)
In-Reply-To: <1321638394.2883.32.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 18 Nov 2011 17:46:34 +0000
> On Fri, 2011-11-18 at 17:48 +0100, Olaf Hering wrote:
>> Add .get_settings function, return fake data so that ethtool can get
>> enough information. For some application like VCS, this is useful,
>> otherwise some of application logic will get panic.
>> The reported data refers to VMWare vmxnet.
>>
>> Signed-off-by: Xin Wei Hu <xwhu@suse.com>
>> Signed-off-by: Chunyan Liu <cyliu@suse.com>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> NAK, we should not just make things up.
Agreed, if you cannot determine the values with certainty do not
implement this method.
Fix the tools which cannot function without this information.
prev parent reply other threads:[~2011-11-18 19:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 16:48 [PATCH] xen-netfront: report link speed to ethtool Olaf Hering
2011-11-18 17:46 ` Ben Hutchings
2011-11-18 18:43 ` Olaf Hering
2011-11-18 19:10 ` Ben Hutchings
2011-11-18 19:17 ` Olaf Hering
2011-11-18 18:44 ` Rick Jones
2011-11-18 18:46 ` Jeremy Fitzhardinge
2011-11-18 18:58 ` use a special value of -2 for virtual devices to report indeterminate speed? Rick Jones
2011-11-18 19:13 ` Ben Hutchings
2011-11-18 19:11 ` [PATCH] xen-netfront: report link speed to ethtool Pavel Matěja
2011-11-18 19:37 ` Pasi Kärkkäinen
2011-11-19 1:13 ` James Harper
2011-11-19 1:32 ` James Harper
2011-11-18 19:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118.141149.231957666935653299.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).