From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: annie li <annie.li@oracle.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
"jeremy@goop.org" <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Durrant <Paul.Durrant@citrix.com>
Subject: Re: [Xen-devel] Re: [PATCH 2/3] xen/granttable: Grant tables V2 implementation
Date: Fri, 18 Nov 2011 13:05:00 -0500 [thread overview]
Message-ID: <20111118180500.GA19469@phenom.dumpdata.com> (raw)
In-Reply-To: <4EC6837F.1050201@oracle.com>
> So we have two candidates:
> xen_raw_printk + panic
> panic + earlyprintk=xen
>
> If panic does work with earlyprintk, then the latter one is better.
> Otherwise, there will be duplicated string printed out with
> 'earlyprintk=xen'.
The idea is just to have one function. Whichever prints the
string and panics the machine. If 'panic' does this properly
(and properly meaning it actually prints data when using
the earlyprintk=xen as well as console=hvc0) printout system
the we cuold just use 'panic' and not worry about it.
But if it does not, then we (and by we I mean you) should
provide a variant of panic() that prints the data properly using the
earlprintk mechanism. Preferrabily to make it generic.
next prev parent reply other threads:[~2011-11-18 18:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 13:10 Improved patches of upstreaming grant table version 2 annie li
2011-11-16 13:23 ` [Xen-devel] " annie li
2011-11-16 13:48 ` [PATCH 1/3] xen/granttable: Introducing grant table V2 stucture annie.li
2011-11-17 10:35 ` Ian Campbell
2011-11-17 16:06 ` annie li
2011-11-17 16:29 ` Konrad Rzeszutek Wilk
2011-11-18 3:08 ` ANNIE LI
2011-11-17 16:55 ` Ian Campbell
2011-11-18 10:07 ` [Xen-devel] " ANNIE LI
2011-11-18 10:54 ` Ian Campbell
2011-11-18 16:02 ` annie li
2011-11-18 16:04 ` [Xen-devel] " Ian Campbell
2011-11-21 9:51 ` ANNIE LI
2011-11-21 10:36 ` Ian Campbell
2011-11-16 13:49 ` [PATCH 2/3] xen/granttable: Grant tables V2 implementation annie.li
2011-11-18 10:13 ` ANNIE LI
2011-11-18 11:02 ` Ian Campbell
2011-11-18 13:52 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-11-18 14:00 ` Ian Campbell
2011-11-18 16:10 ` annie li
2011-11-18 18:05 ` Konrad Rzeszutek Wilk [this message]
2011-11-19 3:36 ` annie li
2011-11-21 9:51 ` ANNIE LI
2011-11-21 10:35 ` Ian Campbell
2011-11-21 11:42 ` annie li
2011-11-16 13:50 ` [PATCH 3/3] xen/granttable: Keep code format clean annie.li
2011-11-18 10:16 ` ANNIE LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118180500.GA19469@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=annie.li@oracle.com \
--cc=jeremy@goop.org \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).