From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 4 of 4] xenpaging: initial libxl support Date: Sun, 20 Nov 2011 19:29:51 +0100 Message-ID: <20111120182951.GA4830@aepfle.de> References: <20111107125535.GA16522@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: George Dunlap , "xen-devel@lists.xensource.com" , Ian Campbell List-Id: xen-devel@lists.xenproject.org On Mon, Nov 07, Stefano Stabellini wrote: > On Mon, 7 Nov 2011, Olaf Hering wrote: > > > If tot_memkb is the pod target of the domain, we should be coherent and > > > set it equal to target_memkb when paging is inactive. > > > > So far PoD and paging are unrelated and mean different things. > > I think the difference between max_memkb and tot_memkb could be the > > trigger to start paging. > > Yes, I think it would be better. I have to disagree here. After looking at the code in parse_config_data(), tot_memkb is only set if actmem= is listed in the configfile. And if actmem= is set, its the trigger to run xenpaging and let it work toward the specified number. So checking for a non-null tot_memkb in create_xenpaging() looks like the correct way to me to decide wether xenpaging should be started. Olaf