From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: ANNIE LI <annie.li@oracle.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jeremy@goop.org" <jeremy@goop.org>,
"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>,
Paul Durrant <Paul.Durrant@citrix.com>
Subject: Re: [PATCH 3/4] xen/granttable: Grant tables V2 implementation
Date: Tue, 22 Nov 2011 09:31:23 -0500 [thread overview]
Message-ID: <20111122143123.GA3430@phenom.dumpdata.com> (raw)
In-Reply-To: <4ECB7324.9080008@oracle.com>
On Tue, Nov 22, 2011 at 06:02:12PM +0800, ANNIE LI wrote:
>
>
> On 2011-11-22 17:29, Ian Campbell wrote:
> >On Tue, 2011-11-22 at 01:59 +0000, annie.li@oracle.com wrote:
> >[...]
> >>+#ifdef CONFIG_X86
> >>+ barrier();
> >>+#else
> >>+ mb();
> >>+#endif
> >>+ }
> >Niggle: Indentation of this final } is off.
> Sorry, I did not notice that.
> >Otherwise all 4 patches:
> >Acked-by: Ian Campbell<ian.campbell@citrix.com>
> >
> >[...]
> Thanks, I will resend those patches after above indentation issue is fixed.
That is OK. I can modify them.
>
> Thanks.
>
> Thanks
> Annie
next prev parent reply other threads:[~2011-11-22 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 12:17 Third version patches for upstreaming grant table version 2 annie li
2011-11-22 1:58 ` [PATCH 1/4] xen/granttable: Introducing grant table V2 stucture annie.li
2011-11-22 1:58 ` [PATCH 2/4] xen/granttable: Refactor some code annie.li
2011-11-22 1:59 ` [PATCH 3/4] xen/granttable: Grant tables V2 implementation annie.li
2011-11-22 9:29 ` Ian Campbell
2011-11-22 10:02 ` ANNIE LI
2011-11-22 14:31 ` Konrad Rzeszutek Wilk [this message]
2011-11-22 1:59 ` [PATCH 4/4] xen/granttable: Keep code format clean annie.li
-- strict thread matches above, loose matches on Subject: below --
2011-11-22 10:21 Forth version patches for upstreaming grant table version 2 ANNIE LI
2011-11-22 10:27 ` [PATCH 3/4] xen/granttable: Grant tables V2 implementation annie.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122143123.GA3430@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=annie.li@oracle.com \
--cc=jeremy@goop.org \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).