From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Wang2 <wei.wang2@amd.com>
Subject: Re: [PATCH 12 of 16] hvmloader: Build IVRS table
Date: Fri, 23 Dec 2011 12:52:08 +0100
Message-ID: <201112231252.08628.wei.wang2@amd.com>
References: <patchbomb.1324639749@gran.amd.com>
	<bb76ba2457e629d668c0.1324639761@gran.amd.com>
	<1324640192.7877.152.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1324640192.7877.152.camel@zakaz.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, "JBeulich@suse.com" <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Friday 23 December 2011 12:36:32 Ian Campbell wrote:
> On Fri, 2011-12-23 at 11:29 +0000, Wei Wang wrote:
> > diff -r b70cf1dcb110 -r bb76ba2457e6
> > xen/include/public/hvm/hvm_info_table.h
> > --- a/xen/include/public/hvm/hvm_info_table.h   Thu Dec 22 16:56:45
> > 2011 +0100
> > +++ b/xen/include/public/hvm/hvm_info_table.h   Thu Dec 22 16:56:48
> > 2011 +0100
> > @@ -67,6 +67,9 @@ struct hvm_info_table {
> >
> >      /* Bitmap of which CPUs are online at boot time. */
> >      uint8_t     vcpu_online[(HVM_MAX_VCPUS + 7)/8];
> > +
> > +    /* guest iommu enabled */
> > +    uint8_t     iommu_enabled;
> >  };
> >
> >  #endif /* __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__ */
>
> Please can we avoid adding new things to this struct and use xenstore to
> pass new configuration items instead. See Paul Durrant's recent patches
> to make s3 optional via the platform/acpi_s3 node.
> Ian.
Good point, Will use xenstore_read in next try.
Thanks,
Wei