From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Wang2 <wei.wang2@amd.com>
Subject: Re: [PATCH 06 of 16] amd iommu: add ppr log processing
	into iommu interrupt handling
Date: Tue, 3 Jan 2012 09:58:06 +0100
Message-ID: <201201030958.08981.wei.wang2@amd.com>
References: <patchbomb.1324639749@gran.amd.com>
	<bf9f21ad9a0ec245b409.1324639755@gran.amd.com>
	<4F01BB6C020000780006A0FE@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4F01BB6C020000780006A0FE@nat28.tlf.novell.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@suse.com>
Cc: keir@xen.org, xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Jan,
Thanks for the review. I will fix all of them in the next try.
Wei

On Monday 02 January 2012 14:13:00 Jan Beulich wrote:
> >>> On 23.12.11 at 12:29, Wei Wang <wei.wang2@amd.com> wrote:
> >
> > --- a/xen/drivers/passthrough/amd/iommu_init.c	Thu Dec 22 16:56:25 2011
> > +0100 +++ b/xen/drivers/passthrough/amd/iommu_init.c	Thu Dec 22 16:56:28
> > 2011 +0100 ...
> >      spin_unlock_irqrestore(&iommu->lock, flags);
> >  }
> >
> > +void parse_ppr_log_entry(struct amd_iommu *iommu, u32 entry[])
>
> static?
>
> > +{
> > +
> > +    u16 device_id;
> >...
>
> Jan