From: Olaf Hering <olaf@aepfle.de>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: andres@gridcentric.ca, xen-devel@lists.xensource.com,
Adin Scannell <adin@scannell.ca>,
JBeulich@suse.com, adin@gridcentric.com
Subject: Re: [PATCH 2/3] Handle GNTST_eagain in kernel drivers
Date: Tue, 3 Jan 2012 19:40:45 +0100 [thread overview]
Message-ID: <20120103184045.GA26720@aepfle.de> (raw)
In-Reply-To: <20120103181953.GH749@andromeda.dapyr.net>
On Tue, Jan 03, Konrad Rzeszutek Wilk wrote:
> If this problem does occur (the swapper died in dom0) should the
> printk at least use printk_ratelimited so that we don't cause too much
> noise?
I remember there was no flood because the guest was stuck anyway. But
see below.
> > The caller has to deal with the various !GNTST_okay states anyway, this
> > patch wont change that fact.
>
> Ok, so then we don't really need the printk right? As the caller
> would presumarily do the right thing and also print the error?
I think its more a debug thing, so that I knew something bad happend.
And at that time it was just helpful to get me some understanding of the
code flow. Since now that part of the paging code is reasonable
debugged, the printk is not really needed anymore.
Instead the code who uses these new functionality should have proper
error handling and print reasonable diagnostic messages.
Olaf
next prev parent reply other threads:[~2012-01-03 18:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 3:22 [PATCH] Add necessary bits to pvops Linux for mapping paged-out pages Adin Scannell
2011-12-17 3:22 ` [PATCH 1/3] Make xen_remap_domain_mfn_range return value meaningful in case of error Adin Scannell
2011-12-17 3:22 ` [PATCH 2/3] Handle GNTST_eagain in kernel drivers Adin Scannell
2011-12-17 14:30 ` Konrad Rzeszutek Wilk
2011-12-17 16:53 ` Adin Scannell
2011-12-17 21:31 ` Konrad Rzeszutek Wilk
2012-01-02 16:06 ` Olaf Hering
2012-01-03 18:19 ` Konrad Rzeszutek Wilk
2012-01-03 18:40 ` Olaf Hering [this message]
2012-01-03 18:48 ` Konrad Rzeszutek Wilk
2011-12-17 3:22 ` [PATCH 3/3] Port of mmap_batch_v2 to support paging in Xen Adin Scannell
2011-12-17 14:40 ` Konrad Rzeszutek Wilk
2011-12-17 16:51 ` Adin Scannell
2011-12-17 21:29 ` Konrad Rzeszutek Wilk
2011-12-17 3:49 ` [PATCH] Add necessary bits to pvops Linux for mapping paged-out pages Adin Scannell
2011-12-17 14:16 ` Konrad Rzeszutek Wilk
2011-12-17 14:16 ` Konrad Rzeszutek Wilk
2012-01-02 16:06 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103184045.GA26720@aepfle.de \
--to=olaf@aepfle.de \
--cc=JBeulich@suse.com \
--cc=adin@gridcentric.com \
--cc=adin@scannell.ca \
--cc=andres@gridcentric.ca \
--cc=konrad@darnok.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).