From: Stephen Hemminger <shemminger@vyatta.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, netdev@vger.kernel.org,
xen-devel@lists.xensource.com, konrad.wilk@oracle.com,
david.vrabel@citrix.com, paul.durrant@citrix.com
Subject: Re: [RFC PATCH V2 3/8] netback: switch to NAPI + kthread model
Date: Tue, 17 Jan 2012 09:07:30 -0800 [thread overview]
Message-ID: <20120117090730.13ae3c6e@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1326808024-3744-4-git-send-email-wei.liu2@citrix.com>
On Tue, 17 Jan 2012 13:46:59 +0000
Wei Liu <wei.liu2@citrix.com> wrote:
> This patch implements 1:1 model netback. We utilizes NAPI and kthread
> to do the weight-lifting job:
>
> - NAPI is used for guest side TX (host side RX)
> - kthread is used for guest side RX (host side TX)
>
> This model provides better scheduling fairness among vifs. It also
> lays the foundation for future work.
>
> The major defect for the current implementation is that in the NAPI
> poll handler we don't actually disable interrupt. Xen stuff is
> different from real hardware, it requires some other tuning of ring
> macros.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
The network receive processing is sensitive to the context it is run in.
Normally it is run in softirq with interrupts enabled. With your code,
the poll routine disables IRQ's which shouldn't be necessary.
Why does xenvif_receive_skb() need to still exist? Couldn't it
just be replaced with call to netif_receive_skb() in one place it is called.
next prev parent reply other threads:[~2012-01-17 17:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 13:46 [RFC PATCH V2] New Xen netback implementation Wei Liu
2012-01-17 13:46 ` [RFC PATCH V2 1/8] netback: page pool version 1 Wei Liu
2012-01-17 13:46 ` [RFC PATCH V2 2/8] netback: add module unload function Wei Liu
2012-01-17 13:46 ` [RFC PATCH V2 3/8] netback: switch to NAPI + kthread model Wei Liu
2012-01-17 17:07 ` Stephen Hemminger [this message]
2012-01-17 17:11 ` Wei Liu
2012-01-17 13:47 ` [RFC PATCH V2 4/8] netback: switch to per-cpu scratch space Wei Liu
2012-01-17 13:47 ` [RFC PATCH V2 5/8] netback: add module get/put operations along with vif connect/disconnect Wei Liu
2012-01-17 13:47 ` [RFC PATCH V2 6/8] netback: melt xen_netbk into xenvif Wei Liu
2012-01-17 13:47 ` [RFC PATCH V2 7/8] netback: alter internal function/structure names Wei Liu
2012-01-17 13:47 ` [RFC PATCH V2 8/8] netback: remove unwanted notification generation during NAPI processing Wei Liu
2012-01-27 19:22 ` [RFC PATCH V2] New Xen netback implementation Konrad Rzeszutek Wilk
2012-01-29 13:42 ` Wei Liu
2012-01-29 21:37 ` Konrad Rzeszutek Wilk
2012-01-30 15:01 ` Wei Liu
2012-01-30 18:27 ` Wei Liu
2012-01-30 18:30 ` Wei Liu
2012-01-30 19:41 ` Wei Liu
2012-01-30 15:07 ` Ian Campbell
2012-01-30 15:21 ` Konrad Rzeszutek Wilk
2012-01-30 15:49 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117090730.13ae3c6e@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).