[PATCH] Fix build error

[PATCH] Fix build error

[Masaki Kanno]

Hi,

When I built the latest xen-unstable, I saw the following error messages.
This patch fixes it.

make[6]: Entering directory `/xen/xen-unstable.hg/xen/arch/x86/mm/shadow'
gcc -O2 -fomit-frame-pointer -m32 -march=i686 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -DNDEBUG -nostdinc -fno-builtin -fno-common -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/xen/xen-unstable.hg/xen/include -I/xen/xen-unstable.hg/xen/include/asm-x86/mach-generic -I/xen/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-float -fno-stack-protector -g -D__XEN__ -DGUEST_PAGING_LEVELS=2 -c multi.c -o guest_2.o
cc1: warnings being treated as errors
multi.c: In function ‘emulate_map_dest’:
multi.c:4648: warning: unused variable ‘sreg’
make[6]: *** [guest_2.o] Error 1
make[6]: Leaving directory `/xen/xen-unstable.hg/xen/arch/x86/mm/shadow'
make[5]: *** [shadow/built_in.o] Error 2
make[5]: Leaving directory `/xen/xen-unstable.hg/xen/arch/x86/mm'
make[4]: *** [mm/built_in.o] Error 2
make[4]: Leaving directory `/xen/xen-unstable.hg/xen/arch/x86'
make[3]: *** [/xen/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2
make[3]: Leaving directory `/xen/xen-unstable.hg/xen/arch/x86'
make[2]: *** [/xen/xen-unstable.hg/xen/xen] Error 2
make[2]: Leaving directory `/xen/xen-unstable.hg/xen'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/xen/xen-unstable.hg/xen'
make: *** [install-xen] Error 2


diff -r b0ee5e8613e9 xen/arch/x86/mm/shadow/multi.c
--- a/xen/arch/x86/mm/shadow/multi.c	Tue Jul 29 13:27:29 2008 +0100
+++ b/xen/arch/x86/mm/shadow/multi.c	Wed Jul 30 09:57:17 2008 +0900
@@ -4645,7 +4645,9 @@
                               u32 bytes,
                               struct sh_emulate_ctxt *sh_ctxt)
 {
+#ifndef NDEBUG
     struct segment_register *sreg;
+#endif
     unsigned long offset;
     void *map = NULL;
 

Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com>

Best regards,
 Kan

[PATCH] fix build error

[Kay, Allen M]

[-- Attachment #1.1: Type: text/plain, Size: 143 bytes --]

Attached patch fix build error in latest xen-unstable.hg.

Signed-off-by: Allen Kay <allen.m.kay@intel.com<mailto:allen.m.kay@intel.com>>


[-- Attachment #1.2: Type: text/html, Size: 1854 bytes --]

[-- Attachment #2: build-error.patch --]
[-- Type: application/octet-stream, Size: 664 bytes --]

diff -r 50117a4d1a2c tools/libxl/libxl_json.c
--- a/tools/libxl/libxl_json.c	Mon Jan 02 12:43:07 2012 +0000
+++ b/tools/libxl/libxl_json.c	Wed Jan 04 13:51:00 2012 -0800
@@ -820,9 +820,9 @@ static const char *yajl_gen_status_to_st
             return "generation complete";
         case yajl_gen_invalid_number:
             return "invalid number";
+#if 0 /* This is in the docs but not implemented in the version I am running. */
         case yajl_gen_no_buf:
             return "no buffer";
-#if 0 /* This is in the docs but not implemented in the version I am running. */
         case yajl_gen_invalid_string:
             return "invalid string";
 #endif

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] fix build error

[Ian Campbell]

On Wed, 2012-01-04 at 21:57 +0000, Kay, Allen M wrote:
> Attached patch fix build error in latest xen-unstable.hg.

What is the specific build error?

What version of yajl do you have and on which distro?

Ian.

> 
>  
> 
> Signed-off-by: Allen Kay <allen.m.kay@intel.com>
> 
>  
> 
> 

Re: [PATCH] fix build error

[Wei, Gang]

Ian Campbell wrote on 2012-01-05:
> On Wed, 2012-01-04 at 21:57 +0000, Kay, Allen M wrote:
>> Attached patch fix build error in latest xen-unstable.hg.
> 
> What is the specific build error?
> 
> What version of yajl do you have and on which distro?
> 

I am not try to answer this for Allen, but I also met similar build error(it says yajl_gen_no_buf was not defined) in RHEL6.2 64bit with yajl 1.0.7-3.

Jimmy

Re: [PATCH] fix build error

[Ian Campbell]

On Thu, 2012-01-05 at 15:00 +0000, Wei, Gang wrote:
> Ian Campbell wrote on 2012-01-05:
> > On Wed, 2012-01-04 at 21:57 +0000, Kay, Allen M wrote:
> >> Attached patch fix build error in latest xen-unstable.hg.
> > 
> > What is the specific build error?
> > 
> > What version of yajl do you have and on which distro?
> > 
> 
> I am not try to answer this for Allen, but I also met similar build error(it says yajl_gen_no_buf was not defined) in RHEL6.2 64bit with yajl 1.0.7-3.

I use 1.0.8 so I guess this must be new there.

Any patch which says "fix build error/warning/message" should, IMHO,
always include a verbatim copy of the error message being fixed.

Please can one of you resubmit with the changelog corrected in that
manner?

Eventually we could use autoconf to detect this stuff, although that
does sound rather like overkill...

Ian.

Re: [PATCH] fix build error

[Konrad Rzeszutek Wilk]

On Thu, Jan 05, 2012 at 03:05:21PM +0000, Ian Campbell wrote:
> On Thu, 2012-01-05 at 15:00 +0000, Wei, Gang wrote:
> > Ian Campbell wrote on 2012-01-05:
> > > On Wed, 2012-01-04 at 21:57 +0000, Kay, Allen M wrote:
> > >> Attached patch fix build error in latest xen-unstable.hg.
> > > 
> > > What is the specific build error?
> > > 
> > > What version of yajl do you have and on which distro?
> > > 
> > 
> > I am not try to answer this for Allen, but I also met similar build error(it says yajl_gen_no_buf was not defined) in RHEL6.2 64bit with yajl 1.0.7-3.
> 
> I use 1.0.8 so I guess this must be new there.
> 
> Any patch which says "fix build error/warning/message" should, IMHO,
> always include a verbatim copy of the error message being fixed.
> 
> Please can one of you resubmit with the changelog corrected in that
> manner?

Yes please. You can also add 'Tested-by: Konrad Rzeszutek Wilk
<konrad.wilk@oracle.com>'. Thanks.
> 
> Eventually we could use autoconf to detect this stuff, although that
> does sound rather like overkill...
> 
> Ian.
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: [PATCH] fix build error

[Ian Jackson]

Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH] fix build error"):
> On Thu, Jan 05, 2012 at 03:05:21PM +0000, Ian Campbell wrote:
> > Any patch which says "fix build error/warning/message" should, IMHO,
> > always include a verbatim copy of the error message being fixed.

Yes.

> > Please can one of you resubmit with the changelog corrected in that
> > manner?
> 
> Yes please. You can also add 'Tested-by: Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com>'. Thanks.

This doesn't seem to have been forthcoming and it was all pretty
obvious following this thread so I've committed it now.
Next time it would definitely be nice if we could have a good commit
message and so forth.

> > Eventually we could use autoconf to detect this stuff, although that
> > does sound rather like overkill...

This kind of irritating API instability is exactly what autoconf is
good at.

Ian.