From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad@darnok.org>
Subject: Re: [PATCH] fix build error
Date: Tue, 17 Jan 2012 14:34:12 -0400
Message-ID: <20120117183412.GA16578@andromeda.dapyr.net>
References: <003AAFE53969E14CB1F09B6FD68C3CD4019C28@ORSMSX105.amr.corp.intel.com>
	<1325750535.29084.1.camel@dagon.hellion.org.uk>
	<D0B11485C64D4B47B66902F8A4E901BEFEC0@SHSMSX101.ccr.corp.intel.com>
	<1325775922.25206.395.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <1325775922.25206.395.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "Kay, Allen M" <allen.m.kay@intel.com>, "Wei, Gang" <gang.wei@intel.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, Jan 05, 2012 at 03:05:21PM +0000, Ian Campbell wrote:
> On Thu, 2012-01-05 at 15:00 +0000, Wei, Gang wrote:
> > Ian Campbell wrote on 2012-01-05:
> > > On Wed, 2012-01-04 at 21:57 +0000, Kay, Allen M wrote:
> > >> Attached patch fix build error in latest xen-unstable.hg.
> > > 
> > > What is the specific build error?
> > > 
> > > What version of yajl do you have and on which distro?
> > > 
> > 
> > I am not try to answer this for Allen, but I also met similar build error(it says yajl_gen_no_buf was not defined) in RHEL6.2 64bit with yajl 1.0.7-3.
> 
> I use 1.0.8 so I guess this must be new there.
> 
> Any patch which says "fix build error/warning/message" should, IMHO,
> always include a verbatim copy of the error message being fixed.
> 
> Please can one of you resubmit with the changelog corrected in that
> manner?

Yes please. You can also add 'Tested-by: Konrad Rzeszutek Wilk
<konrad.wilk@oracle.com>'. Thanks.
> 
> Eventually we could use autoconf to detect this stuff, although that
> does sound rather like overkill...
> 
> Ian.
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel