From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear() Date: Fri, 20 Jan 2012 18:55:08 -0500 Message-ID: <20120120235508.GA17260@phenom.dumpdata.com> References: <1327072528-8479-1-git-send-email-akinobu.mita@gmail.com> <1327072528-8479-4-git-send-email-akinobu.mita@gmail.com> <20120120152819.GA3959@phenom.dumpdata.com> <20120120160938.GC3959@phenom.dumpdata.com> <20120120151149.04352aac.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120120151149.04352aac.akpm@linux-foundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Andrew Morton Cc: Jeremy Fitzhardinge Jeremy Fitzhardinge , xen-devel@lists.xensource.com, virtualization@lists.linux-foundation.org, Akinobu Mita , linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org On Fri, Jan 20, 2012 at 03:11:49PM -0800, Andrew Morton wrote: > On Fri, 20 Jan 2012 11:09:38 -0500 > Konrad Rzeszutek Wilk wrote: > > > > > > > > Did you test this patch with a large amount of minors? > > > > > > Sorry I didn't do runtime test. > > > > Please do. > > The poor guy probably doesn't know how to test it and surely it would > be quite a lot of work for him to do so. > > Overall, it would be much more efficient if the tester of this code is > someone who is set up to easily apply the patch and test it. ie: the > code maintainer(s). This patch aside - Andrew how do you deal with a large amount of patches and make sure they are tested? Is there a weekly Test Tuesday where you kick off your automated tests and dilligently look for any variations? Or is it more of compile the kernel with X features and run it for a week doing normal (and abnormal!) things to see if it falls over? Thanks!