From: Olaf Hering <olaf@aepfle.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] pv drivers: wrap xen_cpuid_base()
Date: Mon, 23 Jan 2012 15:22:32 +0100 [thread overview]
Message-ID: <20120123142232.GA8983@aepfle.de> (raw)
In-Reply-To: <4F1D786A020000780006E6D1@nat28.tlf.novell.com>
On Mon, Jan 23, Jan Beulich wrote:
> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
>
> Given that the PV drivers must be building fine for SLE11 SP2, which
> is 3.0-based, I wonder if this really is the correct fix (and doesn't
> rather break the build). The first thing coming to mind is that
> arch/x86/include/asm/xen/hypervisor.h shouldn't get included here
> (and hence there shouldn't be any conflict). Are you perhaps trying
> to build the PV drivers against a pv-ops-enabled configuration (which
> is a wrong to try afaict)?
Its an ordinary kernel-source tree.
git describe d9b8ca8474fd4fdd43ba6d97a4fee8b49b978067
v2.6.37-rc5-2-gd9b8ca8
The function appears in 2.6.38, so I think the version number is correct.
Olaf
next prev parent reply other threads:[~2012-01-23 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 13:49 [PATCH] pv drivers: wrap xen_cpuid_base() Olaf Hering
2012-01-23 14:10 ` Jan Beulich
2012-01-23 14:22 ` Olaf Hering [this message]
2012-01-23 14:48 ` Jan Beulich
2012-01-24 10:27 ` Olaf Hering
2012-01-24 11:17 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123142232.GA8983@aepfle.de \
--to=olaf@aepfle.de \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).