From: Olaf Hering <olaf@aepfle.de>
To: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] tools/libxc: send page-in requests in batches in linux_privcmd_map_foreign_bulk
Date: Thu, 26 Jan 2012 17:38:10 +0100 [thread overview]
Message-ID: <20120126163810.GA9137@aepfle.de> (raw)
In-Reply-To: <317844de67b9293a2e45ecd879a1c58a.squirrel@webmail.lagarcavilla.org>
On Thu, Jan 26, Andres Lagar-Cavilla wrote:
> Olaf,
> if I get a pattern of errors in the err array of the form:
>
> {ENOENT, EWHATEVER, ENOENT, EWHATEVER}
> with EWHATEVER != ENOENT
>
> this patch does not optimize anything.
It will poke all gfns instead of a single one before going to sleep.
> Why not alloc a separate arr2 array, move the gfn's that failed with
> ENOENT there, and retry the whole new arr2 block? You only need to
> allocate arr2 once, to size num. That will batch always, everything.
The errors for gfns are most likely fragmented. Merging the gfns means
they will get a different addr. So the overall layout of arr and err
needs to remain the same.
Olaf
next prev parent reply other threads:[~2012-01-26 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1648.1327589466.1471.xen-devel@lists.xensource.com>
2012-01-26 16:30 ` [PATCH] tools/libxc: send page-in requests in batches in linux_privcmd_map_foreign_bulk Andres Lagar-Cavilla
2012-01-26 16:38 ` Olaf Hering [this message]
2012-01-26 16:58 ` Andres Lagar-Cavilla
2012-01-26 17:02 ` Olaf Hering
2012-01-27 12:35 ` Olaf Hering
2012-03-26 13:22 Olaf Hering
2012-04-02 16:41 ` Ian Jackson
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 14:51 Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126163810.GA9137@aepfle.de \
--to=olaf@aepfle.de \
--cc=andres@lagarcavilla.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).