From: Tim Deegan <tim@xen.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] xenpaging: unify return value in nominate and evict
Date: Mon, 30 Jan 2012 10:36:51 +0000 [thread overview]
Message-ID: <20120130103651.GD96325@ocelot.phlegethon.org> (raw)
In-Reply-To: <20120130102412.GA9935@aepfle.de>
At 11:24 +0100 on 30 Jan (1327922652), Olaf Hering wrote:
> On Mon, Jan 30, Tim Deegan wrote:
>
> > I don't think EAGAIN is the right thing to return here. There's no
> > reason to think that retrying an invalid GFN will work next time.
> >
> > I'd be happy for these cases all to return the same code, but maybe
> > EINVAL would be a better choice.
>
> EINVAL is returned by upper layers already. I think both nominate and
> evict should return EBUSY in case of failure, this is most likely unique
> enough to mean "request reached target function, and failed.".
Fair enough; EBUSY will do.
Tim.
next prev parent reply other threads:[~2012-01-30 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 19:56 [PATCH] xenpaging: unify return value in nominate and evict Olaf Hering
2012-01-30 9:51 ` Tim Deegan
2012-01-30 10:24 ` Olaf Hering
2012-01-30 10:36 ` Tim Deegan [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-30 12:07 Olaf Hering
2012-01-31 9:33 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130103651.GD96325@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).