From: Tim Deegan <tim@xen.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] xenpaging: unify return value in nominate and evict
Date: Tue, 31 Jan 2012 09:33:05 +0000 [thread overview]
Message-ID: <20120131093305.GA25307@ocelot.phlegethon.org> (raw)
In-Reply-To: <17e25c8b6045cd7246e4.1327925241@probook.site>
At 13:07 +0100 on 30 Jan (1327928841), Olaf Hering wrote:
> xenpaging: unify return value in nominate and evict
>
> Let p2m_mem_paging_nominate and p2m_mem_paging_evict return just one
> error number. EINVAL is not very helpful in case of nominate, it can
> happen if the pager tries to nominate a ballooned page. In this case the
> gfn is not backed by a mfn, the pager can not know that. Similar with
> evict, anything can happen between nominate and evict.
>
> This change helps the pager to decide if the returned error is from the
> function itself, or if it happend earlier. In the latter case, it is
> most likely fatal and should be handled as such.
> nominate and evict return EBUSY, which is supposed to mean
> "pager request reached target function, and failed."
Applied, thanks.
Tim.
next prev parent reply other threads:[~2012-01-31 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 12:07 [PATCH] xenpaging: unify return value in nominate and evict Olaf Hering
2012-01-31 9:33 ` Tim Deegan [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 19:56 Olaf Hering
2012-01-30 9:51 ` Tim Deegan
2012-01-30 10:24 ` Olaf Hering
2012-01-30 10:36 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131093305.GA25307@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).