From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH] xenpaging: unify return value in nominate and evict Date: Tue, 31 Jan 2012 09:33:05 +0000 Message-ID: <20120131093305.GA25307@ocelot.phlegethon.org> References: <17e25c8b6045cd7246e4.1327925241@probook.site> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <17e25c8b6045cd7246e4.1327925241@probook.site> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Olaf Hering Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org At 13:07 +0100 on 30 Jan (1327928841), Olaf Hering wrote: > xenpaging: unify return value in nominate and evict > > Let p2m_mem_paging_nominate and p2m_mem_paging_evict return just one > error number. EINVAL is not very helpful in case of nominate, it can > happen if the pager tries to nominate a ballooned page. In this case the > gfn is not backed by a mfn, the pager can not know that. Similar with > evict, anything can happen between nominate and evict. > > This change helps the pager to decide if the returned error is from the > function itself, or if it happend earlier. In the latter case, it is > most likely fatal and should be handled as such. > nominate and evict return EBUSY, which is supposed to mean > "pager request reached target function, and failed." Applied, thanks. Tim.