From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 2 of 5] Clean up locking now that p2m lockups are fully synchronized Date: Thu, 2 Feb 2012 13:10:34 +0000 Message-ID: <20120202131034.GL48883@ocelot.phlegethon.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andres Lagar-Cavilla Cc: george.dunlap@eu.citrix.com, andres@gridcentric.ca, xen-devel@lists.xensource.com, keir.xen@gmail.com, adin@gridcentric.ca List-Id: xen-devel@lists.xenproject.org At 14:56 -0500 on 01 Feb (1328108166), Andres Lagar-Cavilla wrote: > xen/arch/x86/mm/mem_sharing.c | 2 - > xen/arch/x86/mm/mm-locks.h | 4 ++- > xen/arch/x86/mm/p2m-ept.c | 33 ++------------------- > xen/arch/x86/mm/p2m-pod.c | 14 ++++++--- > xen/arch/x86/mm/p2m-pt.c | 45 +++++------------------------ > xen/arch/x86/mm/p2m.c | 64 ++++++++++++++++++++++-------------------- > 6 files changed, 58 insertions(+), 104 deletions(-) > > > With p2m lookups fully synchronized, many routines need not > call p2m_lock any longer. Also, many routines can logically > assert holding the p2m for a specific gfn. > > Signed-off-by: Andres Lagar-Cavilla This looks OK to me, but I'd like an Ack from George as well for the PoD changes. Cheers, Tim.