From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 3/7] arm: link a device tree blob into the xen image Date: Fri, 3 Feb 2012 20:22:08 +0000 Message-ID: <20120203202208.GC78380@ocelot.phlegethon.org> References: <1328296515-25876-1-git-send-email-david.vrabel@citrix.com> <1328296515-25876-4-git-send-email-david.vrabel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1328296515-25876-4-git-send-email-david.vrabel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: David Vrabel Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org At 19:15 +0000 on 03 Feb (1328296511), David Vrabel wrote: > diff --git a/xen/arch/arm/head.S b/xen/arch/arm/head.S > index b98c921..9951f37 100644 > --- a/xen/arch/arm/head.S > +++ b/xen/arch/arm/head.S > @@ -55,6 +55,11 @@ start: > adr r9, start /* r9 := paddr (start) */ > sub r10, r9, r0 /* r10 := phys-offset */ > > + /* FIXME: using the DTB in the .dtb section. */ The rest of this file uses leading tabs for indentation (not for any particular reason except emascs did it by default). I'd be happy with a patch to change to spaces throughout but I'd rather not mix. > + mov r7, #0 Why? > + ldr r8, =_sdtb > + add r8, r10 This should have a comment like 'r8 := paddr (DTB)', to make it clear what you're overriding the previous r8 value with. (Yes, I'm being picky but I really believe you can't over-comment asm, specially wierd start of day stuff.) Cheers, Tim.