Re: [PATCH 1/4] tools/flask: remove libflask

[Olaf Hering <olaf@aepfle.de>]

On Tue, Feb 07, Olaf Hering wrote:

After poking at this some more, isnt the patch removing the libflask
directory? I think it should have removed also all references to that
directory. setup.py (or python 2.6) in SLES11 can not cope with it,
while python 2.7 in openSuSE seems to ignore the remove directory.

I will send a tested patch which removes the references to libflask.

Olaf

> On Fri, Feb 03, Daniel De Graaf wrote:
> 
> > This library has been deprecated since July 2010; remove the in-tree
> > users and library.
> 
> > -	ln -sf libflask.so.$(MAJOR) $(DESTDIR)$(LIBDIR)/libflask.so
> 
> > +++ b/tools/python/setup.py
> > @@ -48,7 +48,7 @@ flask = Extension("flask",
> >                 include_dirs       = [ PATH_XEN, PATH_LIBXC, "xen/lowlevel/flask",
> >                                        "../flask/libflask/include" ],
> >                 library_dirs       = [ PATH_LIBXC, "../flask/libflask" ],
> > -               libraries          = [ "xenctrl", "flask" ],
> > +               libraries          = [ "xenctrl" ],
> >                 depends            = [ PATH_LIBXC + "/libxenctrl.so",
> >                                        XEN_ROOT + "/tools/flask/libflask/libflask.so" ],
> >                 sources            = [ "xen/lowlevel/flask/flask.c" ])
> 
> 
> For some reason this changeset does not cause buildfailures in automated
> testing. My xen-unstable rpm packages fail to build in SLES11, but not in
> openSuSE for some reason.
> 
> Is there a chance that libflask.so is built after this python thing runs?
> In other words: Is there a makefile dependency missing?
> 
> Olaf
> 
> ...
> building 'flask' extension
> error: ../../tools/flask/libflask/libflask.so: No such file or directory
> make[3]: *** [install] Error 1
> make[3]: Leaving directory `/usr/src/packages/BUILD/xen-4.2.24701/non-dbg/tools/python'
> make[2]: *** [subdir-install-python] Error 2
> ...
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>