xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: ian.jackson@citrix.com, xen-devel@lists.xensource.com
Subject: Re: [PATCH 9 of 9] xl: use json output by default
Date: Thu, 9 Feb 2012 08:30:59 +0100	[thread overview]
Message-ID: <20120209073059.GA20712@aepfle.de> (raw)
In-Reply-To: <9e3be181b2b70f521def.1327512259@cosworth.uk.xensource.com>

On Wed, Jan 25, Ian Campbell wrote:

> # HG changeset patch
> # User Ian Campbell <ian.campbell@citrix.com>
> # Date 1327512175 0
> # Node ID 9e3be181b2b70f521defcd55ecbd9967cd206fb2
> # Parent  f43e2015d86f4d4c7dfa4db69f9d580fb3d705d9
> xl: use json output by default
> 
> Move the sxp producing code off into a separate file. It is supported
> for legacy reasons and needn't be updated other than the improve
> compatibility with xm.
> 
> libxl_domain_config is not currently generated by the IDL (adding the
> necessary support for Array types is on my to do list) so hand code
> the json generation function for now.
> 
> Since this rather directly exposes a libxl data structure it's not
> clear what sort of forward compatibility guarantees we can
> make. However it seems like it should be as stable as libxl's own API
> (which we are looking to stabilise)

This leads to build failures with libyajl2:

xl_cmdimpl.c: In function 'printf_info':
xl_cmdimpl.c:300:5: error: statement with no effect [-Werror=unused-value]
xl_cmdimpl.c:300:21: error: expected ';' before 'conf'
xl_cmdimpl.c:306:28: error: 'conf' undeclared (first use in this function)
xl_cmdimpl.c:306:28: note: each undeclared identifier is reported only once for each function it appears in
xl_cmdimpl.c:306:5: error: too many arguments to function 'yajl_gen_alloc'
/usr/include/yajl/yajl_gen.h:118:23: note: declared here
xl_cmdimpl.c:339:5: error: passing argument 3 of 'yajl_gen_get_buf' from incompatible pointer type [-Werror]
/usr/include/yajl/yajl_gen.h:144:30: note: expected 'size_t *' but argument is of type 'unsigned int *'

  reply	other threads:[~2012-02-09  7:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25 17:24 [PATCH 0 of 9] libxl: API updates + xl: JSON Ian Campbell
2012-01-25 17:24 ` [PATCH 1 of 9] libxl: Rename libxl IDL infrastructure Ian Campbell
2012-01-25 17:24 ` [PATCH 2 of 9] libxl: de-hard-tabbify idl.txt Ian Campbell
2012-01-25 17:24 ` [PATCH 3 of 9] libxl: remove libxl_button_press in favour of libxl_send_trigger Ian Campbell
2012-01-26  8:25   ` Ian Campbell
2012-01-25 17:24 ` [PATCH 4 of 9] ocaml: add helper's for Some/None option types Ian Campbell
2012-01-25 17:24 ` [PATCH 5 of 9] ocaml: Topology.get returns an array not a single element Ian Campbell
2012-01-25 17:24 ` [PATCH 6 of 9] libxl: expose cpu topology as a single list of cpu->{node, core, socket} maps Ian Campbell
2012-01-27 18:10   ` Ian Jackson
2012-01-27 18:11     ` Ian Jackson
2012-01-30  9:34       ` Ian Campbell
2012-01-31 14:21     ` Ian Campbell
2012-01-31 14:24       ` Ian Jackson
2012-01-25 17:24 ` [PATCH 7 of 9] libxl: drop libxl_cpuarray -- topology was the only user Ian Campbell
2012-01-27 18:11   ` Ian Jackson
2012-01-25 17:24 ` [PATCH 8 of 9] libxl: add named enum for timer mode Ian Campbell
2012-01-25 17:24 ` [PATCH 9 of 9] xl: use json output by default Ian Campbell
2012-02-09  7:30   ` Olaf Hering [this message]
2012-02-09  8:55     ` Ian Campbell
2012-01-25 17:44 ` BONUS: [PATCH 10 of 9] docs: document /etc/xen/xl.conf Ian Campbell
2012-01-27 18:16 ` [PATCH 0 of 9] libxl: API updates + xl: JSON Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120209073059.GA20712@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).