From: Tim Deegan <tim@xen.org>
To: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Cc: andres@gridcentric.ca, xen-devel@lists.xensource.com,
adin@gridcentric.ca
Subject: Re: [PATCH] x86/mm: Make asserts on types and counts of shared pages more accurate
Date: Thu, 9 Feb 2012 23:32:46 +0000 [thread overview]
Message-ID: <20120209233246.GA20578@ocelot.phlegethon.org> (raw)
In-Reply-To: <61936533ef44253d5e1b7036711d1324.squirrel@webmail.lagarcavilla.org>
At 06:50 -0800 on 09 Feb (1328770222), Andres Lagar-Cavilla wrote:
> > At 01:01 -0500 on 09 Feb (1328749297), Andres Lagar-Cavilla wrote:
> >> xen/arch/x86/mm/mem_sharing.c | 4 +++-
> >> xen/arch/x86/mm/p2m.c | 6 ++++--
> >> 2 files changed, 7 insertions(+), 3 deletions(-)
> >>
> >>
> >> Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
> >
> > NACK, I'm afraid, especially the second one. '<=' comparisons with a
> > number that's made up of a count ORed with a type don't make sense.
> > If you want to test both type and count, just test them separately.
>
> The type I'm ORing with is a mask with single bit set, not a multi-bit
> type mask. And the type is defined as a higher order bit than the count
> mask.
It is right now, but if someone reshuffles the page_info struct again
you don't want it to banjax your super-cunning code. Just test the
thing you need to test. :)
Tim.
prev parent reply other threads:[~2012-02-09 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 6:01 [PATCH] x86/mm: Make asserts on types and counts of shared pages more accurate Andres Lagar-Cavilla
2012-02-09 7:42 ` Tim Deegan
2012-02-09 14:50 ` Andres Lagar-Cavilla
2012-02-09 23:32 ` Tim Deegan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209233246.GA20578@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=adin@gridcentric.ca \
--cc=andres@gridcentric.ca \
--cc=andres@lagarcavilla.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).