From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Brook Subject: Re: [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h Date: Tue, 14 Feb 2012 10:52:53 +0000 Message-ID: <201202141052.55100.paul@codesourcery.com> References: <201202102334.40125.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: qemu-devel@nongnu.org Cc: Jan Kiszka , "xen-devel@lists.xensource.com" , "avi@redhat.com" , Paolo Bonzini , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org > Yes, you are right. Also considering that we are only calling > slirp_update_timeout if CONFIG_SLIRP is defined, there is no need for > the !CONFIG_SLIRP dummy version of the function. Looks reasonable to me. Unfortunately I can't remember which combination of headless VM and timer configs caused hangs when this was originally added. If anyone has a setup that suffered timeout-related hangs last time we made this change, please retest with this patch. Otherwise I guess we apply the patch and hope we didn't miss anything. > Author: Stefano Stabellini > Date: Mon Feb 13 11:25:03 2012 +0000 > > main_loop_wait: block indefinitely > > - remove qemu_calculate_timeout; > > - explicitly size timeout to uint32_t; > > - introduce slirp_update_timeout; > > - pass NULL as timeout argument to select in case timeout is the > maximum value; > > Signed-off-by: Stefano Stabellini Acked-by: Paul Brook