xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Pasi Kärkkäinen" <pasik@iki.fi>
Cc: ke.yu@intel.com, kevin.tian@intel.com, JBeulich@novell.com,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	xen-devel@lists.xensource.com
Subject: Re: [Xen-devel] [RFC] acpi processor and cpufreq harester - aka pipe all of that up to the hypervisor (v3)
Date: Wed, 15 Feb 2012 11:33:41 -0500	[thread overview]
Message-ID: <20120215163340.GD4093@phenom.dumpdata.com> (raw)
In-Reply-To: <20120214183006.GJ12984@reaktio.net>

On Tue, Feb 14, 2012 at 08:30:06PM +0200, Pasi Kärkkäinen wrote:
> On Tue, Feb 14, 2012 at 12:06:46AM -0500, Konrad Rzeszutek Wilk wrote:
> > 
> > This "harvester" (I am horrible with names, if you have any suggestions please
> > tell me them) collects the information that the cpufreq drivers and the
> > ACPI processor code save in the 'struct acpi_processor' and then sends it to
> > the hypervisor.
> > 
> 
> Btw there's a typo in the subject line.. "harester".

Duh!
> 
> I'm not very good with names either: collector? passthru? 

"passthru" sounds better.
> 
> 
> > The driver can be either an module or compiled in. In either mode the driver
> > launches a thread that checks whether an cpufreq driver is registered. If so
> > it reads all the 'struct acpi_processor' data for all online CPUs and sends
> > it to hypervisor. The driver also register a CPU hotplug component - so if a new
> > CPU shows up - it would send the data to the hypervisor for it as well.
> > 
> > I've tested this with success on a variety of Intel and AMD hardware (need
> > a patch to the hypervisor to allow the rdmsr to be passed through). The one
> > caveat is that dom0_max_vcpus inhibits the driver from reading the vCPUs
> > that are not present in dom0. One solution is to boot without dom0_max_vcpus
> > and utilize the 'xl vcpu-set' command to offline the vCPUs. Other one that
> > Nakajima Jun suggested was to hotplug vCPUS in - so bootup dom0 and hotplug
> > the vCPUs in - but I am running in difficulties on how to do this in the hypervisor.
> > 
> 
> When using this driver do you need to pass any options to Xen hypervisor? 
> (cpufreq=something) ? 

No need. You only need that if you want to change the default cpufreq driver from
the ondemand to performance (so cpufreq=performance) or want more verbose information:
cpufreq=verbose,performance

By default the Xen hypervisor will take the cpufreq data in account unless you
override that with 'dom0-is-deciding-power-management-and-I-cant-remember-exactly'
parameter.

> 
> It might be good to mention something about that in the patch comments.

I will include cpufreq=verbose and mention that the effect before and after. And also
with xenpm.

Thanks!
> 
> -- Pasi
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-02-15 16:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14  5:06 [RFC] acpi processor and cpufreq harester - aka pipe all of that up to the hypervisor (v3) Konrad Rzeszutek Wilk
2012-02-14  5:06 ` [PATCH 1/3] xen/setup/pm/acpi: Remove the call to boot_option_idle_override Konrad Rzeszutek Wilk
2012-02-14  5:06 ` [PATCH 2/3] xen/enlighten: Expose MWAIT and MWAIT_LEAF if hypervisor OKs it Konrad Rzeszutek Wilk
2012-02-14  5:06 ` [PATCH 3/3] xen/acpi/cpufreq: Provide an driver that passes struct acpi_processor data to the hypervisor Konrad Rzeszutek Wilk
2012-02-14 18:30 ` [Xen-devel] [RFC] acpi processor and cpufreq harester - aka pipe all of that up to the hypervisor (v3) Pasi Kärkkäinen
2012-02-15 16:33   ` Konrad Rzeszutek Wilk [this message]
2012-02-21  0:07   ` [RFC] follow-on patches to acpi processor and cpufreq harvester^H^H^Hpassthru (v4) Konrad Rzeszutek Wilk
2012-02-21  0:07     ` [PATCH 1/3] xen/processor-passthru: Change the name to processor-passthru Konrad Rzeszutek Wilk
2012-02-21  0:07     ` [PATCH 2/3] xen/processor-passthru: Support vCPU != pCPU - aka dom0_max_vcpus Konrad Rzeszutek Wilk
2012-02-21  0:07     ` [PATCH 3/3] xen/processor-passthru: Remove the print_hex_dump - as it is difficult to decipher it Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120215163340.GD4093@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=JBeulich@novell.com \
    --cc=ke.yu@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasik@iki.fi \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).