From mboxrd@z Thu Jan  1 00:00:00 1970
From: Philipp Hahn <hahn@univention.de>
Subject: Re: Need help with qemu args debug
Date: Wed, 29 Feb 2012 18:25:27 +0100
Message-ID: <201202291825.31160.hahn@univention.de>
References: <1330513756170-5524689.post@n5.nabble.com>
	<1330514555.4270.52.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4989055526077375934=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1330514555.4270.52.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============4989055526077375934==
Content-Type: multipart/signed;
  boundary="nextPart12332747.0InXCOq4L0";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart12332747.0InXCOq4L0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi,

just a nit:

On Wednesday 29 February 2012 12:22:35 Ian Campbell wrote:
> What I often do is create qemu-debug.sh:
> 	#!/bin/sh
> 	echo "Starting QEMU with: $*" >> /tmp/qemu-dbg.log
> 	exec /usr/lib/xen/bin/qemu-system-i386 $@

You should always put double-quotes arount the $@, otherwise the shell does=
=20
IFS-splitting on the arguments. Probably not that important in this case, b=
ut=20
since this creates nasty quoting problems in general, post "good code" for=
=20
the archive.

Sincerely
Philipp

PS: I know there are broken shell, which don't handle "$@" correct, but hey=
,=20
they're broken anyway.
=2D-=20
Philipp Hahn           Open Source Software Engineer      hahn@univention.de
Univention GmbH        Linux for Your Business        fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
                                                   http://www.univention.de/

--nextPart12332747.0InXCOq4L0
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEABECAAYFAk9OX4cACgkQYPlgoZpUDjmkeQCghu4PQq+04uAqM9rjOyt1JCAq
ql4An2jw5lkOp+uFOKTUBiElNRE+EtEI
=1Rng
-----END PGP SIGNATURE-----

--nextPart12332747.0InXCOq4L0--


--===============4989055526077375934==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4989055526077375934==--