From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] tools/qemu-xen: remove CFLAGS for qemu build
Date: Thu, 1 Mar 2012 20:08:52 +0100
Message-ID: <20120301190852.GA17041@aepfle.de>
References: <5bdbdcb03d60a7b58f41.1330015557@probook.site>
	<20303.46312.444472.874775@mariner.uk.xensource.com>
	<20120301175325.GA8395@aepfle.de>
	<20303.48626.173624.191033@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20303.48626.173624.191033@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, Mar 01, Ian Jackson wrote:

> Olaf Hering writes ("Re: [Xen-devel] [PATCH] tools/qemu-xen: remove CFLAGS for qemu build"):
> > Its a way to pass RPM_OPT_FLAGS to build the tools. This includes things
> > like fortify-source (whatever the exact spelling is) and other global
> > flags to build a distro.
> > What other ways exist to pass that to the buildsystem for the tools?
> 
> This is what EXTRA_CFLAGS and PREPEND_INCLUDES and so forth are for.

With EXTRA_CFLAGS there is even more breakage:

/usr/src/packages/BUILD/xen-4.2.24911/non-dbg/tools/firmware/etherboot/ipxe/src/arch/i386/interface/pcbios/int13.c:1729: undefined reference to `__stack_chk_fail'

I will have a look tomorrow.

Olaf