From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] tools/qemu-xen: remove CFLAGS for qemu build Date: Wed, 14 Mar 2012 19:07:56 +0100 Message-ID: <20120314180756.GA7191@aepfle.de> References: <5bdbdcb03d60a7b58f41.1330015557@probook.site> <20303.46312.444472.874775@mariner.uk.xensource.com> <20120301175325.GA8395@aepfle.de> <20303.48626.173624.191033@mariner.uk.xensource.com> <20120302115125.GA15758@aepfle.de> <20320.35140.322219.894996@mariner.uk.xensource.com> <20120314164615.GA22458@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120314164615.GA22458@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Roger Pau Monne , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Wed, Mar 14, Olaf Hering wrote: > I noticed that @F is empty now, leading to ..d files in all directories. > No idea how to fix that. > tools/Rules.mk:CFLAGS += -MMD -MF .$(@F).d > diff -r 773d03670872 config/Tools.mk.in > --- a/config/Tools.mk.in > +++ b/config/Tools.mk.in > @@ -23,6 +23,10 @@ PREPEND_LIB := @PREPEND_LIB@ > APPEND_INCLUDES := @APPEND_INCLUDES@ > APPEND_LIB := @APPEND_LIB@ > > +CFLAGS := @EXTRA_CFLAGS_XEN_TOOLS@ > +EXTRA_CFLAGS_QEMU_TRADITIONAL := @EXTRA_CFLAGS_QEMU_TRADITIONAL@ > +EXTRA_CFLAGS_QEMU_XEN := @EXTRA_CFLAGS_QEMU_XEN@ The empty @F is fixed by using '+=' instead of ':=' above. With this small change my attempt works for me, CFLAGS get passed properly to qemu and tools itself. Olaf