From: Tim Deegan <tim@xen.org>
To: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Cc: andres@gridcentric.ca, adin@gridcentric.ca, xen-devel@lists.xen.org
Subject: Re: [PATCH 0 of 2] x86/mm: Unsharing ENOMEM handling
Date: Thu, 15 Mar 2012 11:34:47 +0000 [thread overview]
Message-ID: <20120315113447.GF4798@ocelot.phlegethon.org> (raw)
In-Reply-To: <patchbomb.1331566176@xdev.gridcentric.ca>
At 11:29 -0400 on 12 Mar (1331551776), Andres Lagar-Cavilla wrote:
> These two patches were originally posted on Feb 15th as part of a larger
> series.
>
> They were left to simmer as a discussion on wait queues took precedence.
>
> Regardless of the ultimate fate of wait queues, these two patches are necessary
> as they solve some bugs on the memory sharing side. When unsharing fails,
> domains would spin forever, hosts would crash, etc.
>
> The patches also clarify the semantics of unsharing, and comment how it's
> handled.
>
> Two comments against the Feb 15th series taken care of here:
> - We assert that the unsharing code can only return success or ENOMEN.
> - Acked-by Tim Deegan added to patch #1
Applied, thanks.
I'm a bit uneasy about the way this increases the amount of boilerplate
and p2m-related knowledge that's needed at call sites, but it fixes real
problems and I can't see an easy way to avoid it.
Tim.
next prev parent reply other threads:[~2012-03-15 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 15:29 [PATCH 0 of 2] x86/mm: Unsharing ENOMEM handling Andres Lagar-Cavilla
2012-03-12 15:29 ` [PATCH 1 of 2] x86/mm: Allow to not sleep on mem event ring Andres Lagar-Cavilla
2012-03-12 15:29 ` [PATCH 2 of 2] Memory sharing: better handling of ENOMEM while unsharing Andres Lagar-Cavilla
2012-03-15 11:34 ` Tim Deegan [this message]
2012-03-15 14:35 ` [PATCH 0 of 2] x86/mm: Unsharing ENOMEM handling Andres Lagar-Cavilla
2012-03-15 15:36 ` Tim Deegan
2012-03-15 16:44 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315113447.GF4798@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=adin@gridcentric.ca \
--cc=andres@gridcentric.ca \
--cc=andres@lagarcavilla.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).