Re: [PATCH] tools/configure: add options to pass EXTRA_CLFAGS

[Olaf Hering <olaf@aepfle.de>]

On Thu, Mar 15, Roger Pau Monné wrote:


> > To make sure the EXTRA_CFLAGS appear first in the command line
> > tools/Rules.mk must include config/Tools.mk before Config.mk.

> > +++ b/tools/Rules.mk
> > @@ -3,8 +3,8 @@
> >  # `all' is the default target
> >  all:
> >
> > +include $(XEN_ROOT)/config/Tools.mk
> >  include $(XEN_ROOT)/Config.mk
> > -include $(XEN_ROOT)/config/Tools.mk
> 
> Do we really need to change the order? User-defined flags should
> appear after necessary tools build flags, if not a user might use some
> flags that break the build without knowing.

This affects the tools build. If the extra flags really should go to the
end, then APPEND_CFLAGS can be reused and the ordering change above can
be removed.

> >  export _INSTALL := $(INSTALL)
> >  INSTALL = $(XEN_ROOT)/tools/cross-install
> > diff -r 6dd1395c07cb -r 994ac398f4dc tools/configure.ac
> > --- a/tools/configure.ac
> > +++ b/tools/configure.ac
> > @@ -55,6 +55,12 @@ AC_ARG_VAR([APPEND_INCLUDES],
> >     [List of include folders to append to CFLAGS (without -I)])
> >  AC_ARG_VAR([APPEND_LIB],
> >     [List of library folders to append to LDFLAGS (without -L)])
> > +AC_ARG_VAR([EXTRA_CFLAGS_XEN_TOOLS],
> > +    [Extra CFLAGS to build tools])
> > +AC_ARG_VAR([EXTRA_CFLAGS_QEMU_TRADITIONAL],
> > +    [Extra CFLAGS to build qemu-traditional])
> > +AC_ARG_VAR([EXTRA_CFLAGS_QEMU_XEN],
> > +    [Extra CFLAGS to build qemu-xen])
> 
> The change looks good to me in terms of configure modifications, but
> I'm not sure of the names, shouldn't qemu-traditional be
> qemu-xen(-traditional) and qemu-xen be qemu-(xen-)upstream?

I cant comment on that.

What I have seen right now is that other external tools may need their
own EXTRA_CFLAGS_xx variable. Like gcc47 is currently unhappy with ipxe
at least.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel